Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add vm_allocate for apple #3448

Merged
merged 1 commit into from Nov 18, 2023
Merged

add vm_allocate for apple #3448

merged 1 commit into from Nov 18, 2023

Conversation

hjmallon
Copy link
Contributor

We have vm_deallocate, why not vm_allocate too?

I am not totally sure whether these should live here or in mach2?

@rustbot
Copy link
Collaborator

rustbot commented Nov 17, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@JohnTitor
Copy link
Member

If it's related to mach items it should live in mach2, but indeed it's weird that we don't have allocate while we do deallocate, so @bors r+

@bors
Copy link
Contributor

bors commented Nov 18, 2023

📌 Commit d0d0db2 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 18, 2023

⌛ Testing commit d0d0db2 with merge 4ac74f5...

@bors
Copy link
Contributor

bors commented Nov 18, 2023

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 4ac74f5 to main...

@bors bors merged commit 4ac74f5 into rust-lang:main Nov 18, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants