Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo fmt to CONTRIBUTING.md #3454

Closed
wants to merge 1 commit into from

Conversation

arctic-alpaca
Copy link
Contributor

The CI uses cargo +nightly fmt --all -- --check to check code formatting but that's not documented in the "Test before you commit" section of CONTRIBUTING.md.

@rustbot
Copy link
Collaborator

rustbot commented Nov 27, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@JohnTitor
Copy link
Member

Hey, thanks for the PR! I've submitted #3458 to cover more things, closing in favor of that.

@JohnTitor JohnTitor closed this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants