Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop testing on FreeBSD 12 #3475

Merged
merged 1 commit into from Dec 20, 2023
+1 −15
Merged

Stop testing on FreeBSD 12 #3475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 1 addition & 15 deletions .cirrus.yml
View file
Open in desktop
@@ -1,17 +1,3 @@
task:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it s tricky ... logically you re right but in the wild there are many users still taking time to migrate (in another project I had a freebsd ... 9.2 user, a bit extreme :) but you get me ..). I may suggest to give a bit of time before removing it but not up to me..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9.2? Wow. My feeling is that while some users may take some time to upgrade, they also probably aren't using cutting edge Rust software. So those users can probably make do with older crates. No need to maintain the latest Rust releases for old FreeBSD release. At least, that's my philosophy.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. It seems it takes more than this tough see what it took for freebsd 11.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that removing CI doesn't mean that the existing usage on FreeBSD 12 will be broken. The impact of this should be low, I think.

name: nightly x86_64-unknown-freebsd-12
freebsd_instance:
image_family: freebsd-12-4
setup_script:
- pkg install -y libnghttp2 curl
- curl https://sh.rustup.rs -sSf --output rustup.sh
- sh rustup.sh --default-toolchain nightly -y --profile=minimal
- . $HOME/.cargo/env
test_script:
- . $HOME/.cargo/env
- LIBC_CI=1 sh ci/run.sh x86_64-unknown-freebsd
- sh ci/run.sh x86_64-unknown-freebsd

task:
name: nightly x86_64-unknown-freebsd-13
freebsd_instance:
Expand All @@ -29,7 +15,7 @@ task:
task:
name: nightly x86_64-unknown-freebsd-14
freebsd_instance:
image: freebsd-14-0-rc1-amd64
image: freebsd-14-0-release-amd64-ufs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now there is a proper 14 release, image_family: freebsd-14-0 is sufficient.

setup_script:
- pkg install -y libnghttp2 curl
- curl https://sh.rustup.rs -sSf --output rustup.sh
Expand Down