Simplify build.rs by using the question mark operator #3495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JohnTitor (rustbot has picked a reviewer for you, use r? to override) |
samueltardieu
force-pushed
the
question-mark
branch
from
53ebdc1
to
9284cf6
Compare
|
Thanks! But IIRC the question mark operator on Option was stabilized on 1.22 and this would break 0.2's MSRV, I think. Once I create a new release (it should be the final release from the main branch, I think), I'm going to r+ this. |
|
☔ The latest upstream changes (presumably #3498) made this pull request unmergeable. Please resolve the merge conflicts. |
samueltardieu
force-pushed
the
question-mark
branch
from
9284cf6
to
426ad68
Compare
JohnTitor
approved these changes
Jan 7, 2024
|
It's time to go! @bors r+ |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
question_markclippy lint currently overlooks some patterns that could be replaced by the question mark operator. This will be fixed shortly by rust-lang/rust-clippy#11994.