Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock ci: fix wrong cfg emscripten #3684

Merged
merged 2 commits into from May 6, 2024
Merged

Conversation

tesuji
Copy link
Contributor

@tesuji tesuji commented May 6, 2024

CI is currently failing: https://github.com/rust-lang/libc/actions/runs/8961351128/job/24608869921

From https://blog.rust-lang.org/2024/05/06/check-cfg.html, cargo for rust 1.80 always enables rust check-cfg.

@rustbot
Copy link
Collaborator

rustbot commented May 6, 2024

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

tesuji added 2 commits May 7, 2024 02:11
```
warning: target json file contains unused fields: abi-blacklist, family, has-elf-tls, target-env
```
@JohnTitor JohnTitor enabled auto-merge May 6, 2024 19:23
@JohnTitor JohnTitor added this pull request to the merge queue May 6, 2024
Merged via the queue into rust-lang:libc-0.2 with commit 3e7a91e May 6, 2024
57 checks passed
@snogge
Copy link
Contributor

snogge commented May 7, 2024

This is needed on main as well. Is there an automatic way to cherry pick to main, or should someone (me?) prepare a separate PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants