-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add toggle_async_sugar
assist code action
#17258
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
May 18, 2024
maxwase
force-pushed
the
code-assist-async-sugar
branch
3 times, most recently
from
May 18, 2024 17:11
d0192ee
to
723adc7
Compare
Veykril
reviewed
May 23, 2024
Veykril
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
May 23, 2024
There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged. You can start a rebase with the following commands:
The following commits are merge commits: |
maxwase
force-pushed
the
code-assist-async-sugar
branch
from
May 23, 2024 22:10
6becb4b
to
624f99b
Compare
maxwase
force-pushed
the
code-assist-async-sugar
branch
from
May 23, 2024 23:17
0047c44
to
61f8ef5
Compare
Veykril
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
May 27, 2024
Veykril
approved these changes
May 27, 2024
Thanks! |
☀️ Test successful - checks-actions |
lnicola
changed the title
Add
feat: Add Jun 2, 2024
toggle_async_sugar
assist code actiontoggle_async_sugar
assist code action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement code action for sugaring and de-sugaring asynchronous functions.
This code action does not import
Future
trait when de-sugaring and does not touch function boby, I guess this can be implemented later if needed. This action also does not take into consideration other bounds because IMO it's usually "let me try to use sugared version here".Feel free to request changes, that's my first code action implementation 😄
Closes #17010
Relates to #16195