Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the release process with Twitter instructions #517

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pietroalbini
Copy link
Member

As we discussed during the last release team meeting, I talked with @steveklabnik on how to improve the way we tweet new releases to the world, and came up with the following changes to our release process:

  • Added an item to ensure there is someone with Twitter access ready at the start of the release process.
  • Added an optional tweet templates when someone doesn't want to come up with something from scratch.

I also did some tweaks to the T-NN to make them a bit more accurate.

r? @Mark-Simulacrum
cc @rust-lang/release

@@ -106,7 +106,12 @@ Send a PR to the master branch to:

Decide on a time to do the release, T.

- **T-30m** - Run the following command in a shell with [AWS
- **T-50m** - Ensure there is someone with access to the `@rustlang` Twitter
account who'll be able to tweet as soon as we publish the blog post. [Steve
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is too high a bar. I think sending a ping makes sense, but I don't think that we should block on the response. The twitter post is not a critical part of the release, IMO.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of us doing releases can log into the Twitter account, so even if we can't reach out who usually tweets stuff from the account we should be able to post a tweet on our own.

I personally consider tweets to be the way we publicly announce the release is out, along with the blog post, so I'd say we should make sure we have a tweet out.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I guess that's true in some sense, but I also don't see it as critical that we do announce a new release in a push fashion. It makes sense for the release blog post to go out, but the tweet being "late" doesn't seem like a problem to me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have examples in mind of cases where we wouldn't be able to post the tweet? I can't personally think of any, but I'm probably missing something :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally don't really post on Twitter at all, and while I could learn to do so, I think posting the tweet is not necessary for a release to happen; it adds additional complexity.

Part of this is that in the future I'd like to get us to a point where the release is even more hands off than today, and while Twitter does have an API etc, I'm much more hesitant about letting bots post to our twitter than tagging commits and such.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we get to a point where posting the tweet is one of the only manual steps we can reconsider, but for now I'd prefer if we keep tweeting as part of our regular checklist.

I could see us automating tweeting as part of merging blog posts in the future, so the automation doesn't really have to be specific to the release process. Personally I think we're still far from that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I'll be honest, I don't want to learn to push the right buttons and login to 1password, then twitter, etc. for each release I run; I don't consider the tweet anywhere near high priority enough for that to be necessary to execute on the release. I think it should happen, yes, but if it happens +0 or +N hours from the actual release seems unimportant to me... I'm trying to understand why you seem to think differently, but so far don't think I've heard concrete arguments. It feels clear to me that announcing the release and actually running it need not be coupled.

src/release/process.md Show resolved Hide resolved
@pietroalbini
Copy link
Member Author

Moved the non-Twitter changes to #534.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants