Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BETA] Use node_type_opt to skip over generics that were not expected #100548

Closed
wants to merge 1 commit into from
Closed

[BETA] Use node_type_opt to skip over generics that were not expected #100548

wants to merge 1 commit into from

Conversation

compiler-errors
Copy link
Member

@compiler-errors compiler-errors commented Aug 14, 2022 •
edited

Backports #100155
cc #100541
r? @ghost

@compiler-errors compiler-errors added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 14, 2022
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 14, 2022
@compiler-errors compiler-errors marked this pull request as ready for review August 14, 2022 21:15
@compiler-errors compiler-errors changed the title opt node type [BETA] Use node_type_opt to skip over generics that were not expected Aug 14, 2022
@estebank
Copy link
Contributor

strongly in favor of backporting (due to being well targeted, low risk and high reward, these kind of ICEs are not that hard to hit when writing code)

@pnkfelix
Copy link
Member

discussed at T-compiler meeting.

@rustbot label: beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Aug 18, 2022
@ehuss
Copy link
Contributor

ehuss commented Aug 31, 2022

Closing as rolled up in #101221.

@ehuss ehuss closed this Aug 31, 2022
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 1, 2022
@compiler-errors compiler-errors deleted the beta-issue-100154 branch August 11, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@compiler-errors @estebank @pnkfelix @ehuss @Mark-Simulacrum @rustbot