Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated --check-cfg syntax #117981

Merged
merged 4 commits into from Dec 7, 2023
Merged

Remove deprecated --check-cfg syntax #117981

merged 4 commits into from Dec 7, 2023

Conversation

Urgau
Copy link
Contributor

@Urgau Urgau commented Nov 16, 2023

This PR removes the deprecated --check-cfg names(...) and values(...) syntax.

Follow up to #111072
Part of rust-lang/compiler-team#636

r? compiler

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 16, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Nov 16, 2023

Some changes occurred in src/tools/rust-analyzer

cc @rust-lang/rust-analyzer

@Urgau
Copy link
Contributor Author

Urgau commented Nov 16, 2023

Some changes occurred in src/tools/rust-analyzer

I've update the libc version to 0.2.150 which includes some changes necessary for this PR. Let me know if you prefer those changes to be directly made in the rust-analyzer repo.

@lnicola
Copy link
Member

lnicola commented Nov 16, 2023

Let me know if you prefer those changes to be directly made in the rust-analyzer repo.

Yes, very much, but if it's required for this PR, we'll need a sync PR before this lands.

@lnicola lnicola mentioned this pull request Nov 16, 2023
Merged
bors added a commit to rust-lang/rust-analyzer that referenced this pull request Nov 16, 2023
@bors
Auto merge of #15913 - lnicola:bump-libc, r=lnicola
141fc69 
internal: Bump libc

CC rust-lang/rust#117981
@lnicola lnicola mentioned this pull request Nov 16, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 16, 2023
@bors
Auto merge of rust-lang#117985 - lnicola:sync-from-ra, r=lnicola
2c962ec 
Subtree update of `rust-analyzer`

r? `@ghost`

Out of band, but required for rust-lang#117981.
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 17, 2023
@bors
Auto merge of rust-lang#117985 - lnicola:sync-from-ra, r=lnicola
00bfd6b 
Subtree update of `rust-analyzer`

r? `@ghost`

Out of band, but required for rust-lang#117981.
@Urgau Urgau force-pushed the check-cfg-remove-deprecated-syntax branch from c6b1230 to f405a1c Compare November 17, 2023 13:46
@bors
Copy link
Contributor

bors commented Nov 21, 2023

☔ The latest upstream changes (presumably #118134) made this pull request unmergeable. Please resolve the merge conflicts.

@Urgau Urgau force-pushed the check-cfg-remove-deprecated-syntax branch 2 times, most recently from 7397a4d to 623e99e Compare November 22, 2023 10:07
@b-naber
Copy link
Contributor

b-naber commented Dec 4, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 4, 2023

📌 Commit 623e99e has been approved by b-naber

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 4, 2023
fee1-dead added a commit to fee1-dead-contrib/rust that referenced this pull request Dec 5, 2023
@fee1-dead
Rollup merge of rust-lang#117981 - Urgau:check-cfg-remove-deprecated-…
dfa6ff7 
…syntax, r=b-naber

Remove deprecated `--check-cfg` syntax

This PR removes the deprecated `--check-cfg` `names(...)` and `values(...)` syntax.

Follow up to rust-lang#111072
Part of rust-lang/compiler-team#636

r? compiler
@fee1-dead fee1-dead mentioned this pull request Dec 5, 2023
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 5, 2023
@bors
Auto merge of rust-lang#118641 - fee1-dead-contrib:rollup-2qlatcy, r=…
0c029c8 
…fee1-dead

Rollup of 8 pull requests

Successful merges:

 - rust-lang#117922 (Tweak unclosed generics errors)
 - rust-lang#117981 (Remove deprecated `--check-cfg` syntax)
 - rust-lang#118471 (Fix typos in README.md)
 - rust-lang#118488 (Change prefetch to avoid deadlock)
 - rust-lang#118605 (Remove `#[rustc_host]`, use internal desugaring)
 - rust-lang#118608 (Use default params until effects in desugaring)
 - rust-lang#118614 (Update books)
 - rust-lang#118637 (rustc_symbol_mangling,rustc_interface,rustc_driver_impl: Enforce `rustc::potential_query_instability` lint)

r? `@ghost`
`@rustbot` modify labels: rollup
@fee1-dead
Copy link
Member

#118641 (comment)

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 5, 2023
@Urgau Urgau force-pushed the check-cfg-remove-deprecated-syntax branch from 623e99e to 3f0369e Compare December 5, 2023 12:29
@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 5, 2023
@Urgau Urgau force-pushed the check-cfg-remove-deprecated-syntax branch 3 times, most recently from 81591ea to 3f0369e Compare December 5, 2023 14:09
@Urgau
Copy link
Contributor Author

Urgau commented Dec 5, 2023

After some trouble finding a runner that actually test the step that broke, I can confirm that it is solved by 801bc56 (cf. temporary x86_64-gnu runner).

The PR can be re-approved.

@rustbot labels -T-bootstrap -T-infra -A-testsuite -S-waiting-on-author +S-waiting-on-review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 5, 2023
@est31
Copy link
Member

est31 commented Dec 6, 2023

@bors r=b-naber

@bors
Copy link
Contributor

bors commented Dec 6, 2023

📌 Commit 3f0369e has been approved by b-naber

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 6, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 6, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 6, 2023
@bors
Auto merge of rust-lang#118687 - matthiaskrgr:rollup-317ztgu, r=matth…
8235469 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#117981 (Remove deprecated `--check-cfg` syntax)
 - rust-lang#118177 (Suppress warnings in LLVM wrapper when targeting MSVC)
 - rust-lang#118317 (tip for define macro name after `macro_rules!`)
 - rust-lang#118504 (Enforce `must_use` on associated types and RPITITs that have a must-use trait in bounds)
 - rust-lang#118660 (rustc_arena: add `alloc_str`)
 - rust-lang#118681 (Fix is_foreign_item for StableMIR instance )

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f546b44 into rust-lang:master Dec 7, 2023
18 of 22 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Dec 7, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 7, 2023
@rust-timer
Unrolled build for rust-lang#117981
3773c70 
Rollup merge of rust-lang#117981 - Urgau:check-cfg-remove-deprecated-syntax, r=b-naber

Remove deprecated `--check-cfg` syntax

This PR removes the deprecated `--check-cfg` `names(...)` and `values(...)` syntax.

Follow up to rust-lang#111072
Part of rust-lang/compiler-team#636

r? compiler
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request Apr 7, 2024
@bors
Auto merge of #117985 - lnicola:sync-from-ra, r=lnicola
a399abd 
Subtree update of `rust-analyzer`

r? `@ghost`

Out of band, but required for rust-lang/rust#117981.
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request Apr 27, 2024
@bors
Auto merge of #117985 - lnicola:sync-from-ra, r=lnicola
0ece9d0 
Subtree update of `rust-analyzer`

r? `@ghost`

Out of band, but required for rust-lang/rust#117981.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnicola lnicola lnicola left review comments

@b-naber b-naber b-naber approved these changes

Assignees

@b-naber b-naber

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Urgau @rust-log-analyzer @rustbot @lnicola @bors @b-naber @fee1-dead @est31