Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't discourage implementing core::fmt::Write #76750

Merged
merged 1 commit into from
Oct 9, 2020
Merged

Don't discourage implementing core::fmt::Write #76750

merged 1 commit into from
Oct 9, 2020

Conversation

camelid
Copy link
Member

@camelid camelid commented Sep 15, 2020 •
edited by Mark-Simulacrum

Fixes #76729.

Explain when you should use it and when you should not.

@rustbot rustbot added A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Sep 15, 2020
@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 15, 2020
camelid
camelid commented Sep 15, 2020
View reviewed changes
library/core/src/fmt/mod.rs Outdated Show resolved Hide resolved
@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2020
@camelid camelid force-pushed the dont-discourage-core-fmt-write branch from 76ed801 to ce01363 Compare September 27, 2020 23:37
@camelid
Copy link
Member Author

camelid commented Sep 27, 2020

Rebased.

camelid
camelid commented Sep 27, 2020
View reviewed changes
Copy link
Member Author

@camelid camelid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@workingjubilee Is this a better description?

@camelid camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 27, 2020
Mark-Simulacrum
Mark-Simulacrum reviewed Sep 30, 2020
View reviewed changes
library/core/src/fmt/mod.rs Outdated Show resolved Hide resolved
library/core/src/fmt/mod.rs Outdated Show resolved Hide resolved
@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2020
@camelid camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 30, 2020
@workingjubilee
Copy link
Contributor

This looks good!

@camelid
Copy link
Member Author

camelid commented Sep 30, 2020

Okay, ready for a final review!

@camelid camelid added the A-fmt Area: std::fmt label Sep 30, 2020
@camelid
Copy link
Member Author

camelid commented Oct 2, 2020

Squashed.

@camelid camelid force-pushed the dont-discourage-core-fmt-write branch from 9127f52 to 32ad7b2 Compare October 2, 2020 18:51
@camelid
Copy link
Member Author

camelid commented Oct 2, 2020

@Mark-Simulacrum could you re-review this? I addressed @workingjubilee's comments.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2020
@camelid camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 4, 2020
@Mark-Simulacrum Mark-Simulacrum added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 4, 2020
@Mark-Simulacrum Mark-Simulacrum removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 4, 2020
@camelid
Copy link
Member Author

camelid commented Oct 4, 2020

Hmm, I'm not sure why you added S-waiting-on-author; I'm waiting on a review for my newest commit.

@camelid camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 4, 2020
@camelid camelid added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 4, 2020
@camelid
Copy link
Member Author

camelid commented Oct 5, 2020

@Mark-Simulacrum I shortened and simplified it, and I went with something similar to what you suggested.

@bors

This comment has been minimized.

Sign in to view
@camelid camelid force-pushed the dont-discourage-core-fmt-write branch from c40e1ab to 9e88286 Compare October 5, 2020 21:20
@camelid
Copy link
Member Author

camelid commented Oct 5, 2020

Rebased.

@Mark-Simulacrum
Copy link
Member

Please squash the commits, r=me with that done.

@camelid
Don't discourage implementing core::fmt::Write
c17d067 
Explain when you should use it and when you should not.
@camelid
Copy link
Member Author

camelid commented Oct 8, 2020

Squashed.

@camelid camelid force-pushed the dont-discourage-core-fmt-write branch from 9e88286 to c17d067 Compare October 8, 2020 17:50
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 8, 2020

📌 Commit c17d067 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2020
@jonas-schievink jonas-schievink mentioned this pull request Oct 8, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 8, 2020
@bors
Auto merge of rust-lang#77723 - jonas-schievink:rollup-htz44r4, r=jon…
8a84c4f 
…as-schievink

Rollup of 8 pull requests

Successful merges:

 - rust-lang#76750 (Don't discourage implementing `core::fmt::Write`)
 - rust-lang#77449 (BTreeMap: comment why drain_filter's size_hint is somewhat pessimistic)
 - rust-lang#77660 ((docs): make mutex error comment consistent with codebase)
 - rust-lang#77663 (Add compile fail test for issue 27675)
 - rust-lang#77673 (Remove unnecessary lamda on emitter map.)
 - rust-lang#77701 (Make `max_log_info` easily greppable (for figuring out why debug logging is disabled))
 - rust-lang#77702 (Remove not needed lambda.)
 - rust-lang#77710 (Update submodule llvm to get LVI bugfix)

Failed merges:

r? `@ghost`
@bors bors merged commit 2766b72 into rust-lang:master Oct 9, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 9, 2020
@camelid camelid deleted the dont-discourage-core-fmt-write branch October 9, 2020 01:04
@camelid camelid mentioned this pull request Oct 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

@workingjubilee workingjubilee workingjubilee left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools A-fmt Area: std::fmt S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.

Don't discourage people from using std::fmt::Write
6 participants
@camelid @rust-highfive @workingjubilee @bors @Mark-Simulacrum @rustbot