Stabilize span_open() and span_close(). #86136
Conversation
m-ou-se
added
T-libs-api
rust-highfive
added
the
S-waiting-on-review
|
@rfcbot merge |
|
Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rfcbot
added
proposed-final-comment-period
jonas-schievink
added
the
relnotes
|
Seems fine. |
rfcbot
added
final-comment-period
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
rfcbot
added
finished-final-comment-period
|
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. The RFC will be merged soon. |
|
@bors r+ rollup |
|
📌 Commit 6288aad has been approved by |
bors
added
S-waiting-on-bors
… r=m-ou-se Stabilize span_open() and span_close(). This proposes to stabilize `Group::span_open()` and `Group::span_close()`. These are part of the `proc_macro_span` feature gate tracked in rust-lang#54725 Most of the features gated behind `proc_macro_span` are about source location information (file path, line and column information), expansion information (parent()), source_text(), etc. Those are not ready for stabilizaiton. However, getting the span of the `(` and `)` separately instead of only of the entire `(...)` can be very useful in proc macros, and doesn't seem blocked on anything that all the other parts of `proc_macro_span` are blocked on. So, this renames the feature gate for those two functions to `proc_macro_group_span` and stabilizes them.
Rollup of 9 pull requests Successful merges: - rust-lang#86136 (Stabilize span_open() and span_close().) - rust-lang#86359 (Use as_secs_f64 in JunitFormatter) - rust-lang#86370 (Fix rustdoc stabilized versions layout) - rust-lang#86397 (Alter std::cell::Cell::get_mut documentation) - rust-lang#86407 (Use `map_or` instead of open-coding it) - rust-lang#86425 (Update rustversion to 1.0.5) - rust-lang#86440 (Update library tracking issue for libs-api rename.) - rust-lang#86444 (Fix ICE with `#[repr(simd)]` on enum) - rust-lang#86453 (stdlib: Fix typo in internal RefCell docs ) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
@XAMPPRocky This isn’t in current relnotes? |
This proposes to stabilize
Group::span_open()andGroup::span_close().These are part of the
proc_macro_spanfeature gate tracked in #54725Most of the features gated behind
proc_macro_spanare about source location information (file path, line and column information), expansion information (parent()), source_text(), etc. Those are not ready for stabilizaiton. However, getting the span of the(and)separately instead of only of the entire(...)can be very useful in proc macros, and doesn't seem blocked on anything that all the other parts ofproc_macro_spanare blocked on. So, this renames the feature gate for those two functions toproc_macro_group_spanand stabilizes them.