Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #86457

Closed
wants to merge 27 commits into from

Commits on Jun 8, 2021

  1. Configuration menu
    Copy the full SHA
    6288aad View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2021

  1. Configuration menu
    Copy the full SHA
    e4b3131 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    210e46b View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2021

  1. Fix rustdoc stabilized versions layout

    Matteo Briani committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    68f9172 View commit details
    Browse the repository at this point in the history
  2. Alter std::cell::Cell::get_mut documentation

    I find this more consistent with RefCell's equivalent method.
    Eosis committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    7cadf7b View commit details
    Browse the repository at this point in the history
  3. simplify borrowing

    syvb committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    1d5acca View commit details
    Browse the repository at this point in the history
  4. Explicitly write out all fields

    syvb committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    281dd6d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    382ba79 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2021

  1. Configuration menu
    Copy the full SHA
    88abd7d View commit details
    Browse the repository at this point in the history
  2. Make clippy tests happy

    hi-rustin committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    d7bb746 View commit details
    Browse the repository at this point in the history
  3. Address comment

    hi-rustin committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    884336e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f6adaed View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8776b0f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e7a1186 View commit details
    Browse the repository at this point in the history
  7. fix typos

    nikomatsakis committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    831759a View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2021

  1. Configuration menu
    Copy the full SHA
    c688e70 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#86136 - m-ou-se:proc-macro-open-close-span,…

    … r=m-ou-se
    
    Stabilize span_open() and span_close().
    
    This proposes to stabilize `Group::span_open()` and `Group::span_close()`.
    
    These are part of the `proc_macro_span` feature gate tracked in rust-lang#54725
    
    Most of the features gated behind `proc_macro_span` are about source location information (file path, line and column information), expansion information (parent()), source_text(), etc. Those are not ready for stabilizaiton. However, getting the span of the `(` and `)` separately instead of only of the entire `(...)` can be very useful in proc macros, and doesn't seem blocked on anything that all the other parts of `proc_macro_span` are blocked on. So, this renames the feature gate for those two functions to `proc_macro_group_span` and stabilizes them.
    Dylan-DPC committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    488a068 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#86359 - fee1-dead:f64-junit-formatter, r=Jo…

    …hnTitor
    
    Use as_secs_f64 in JunitFormatter
    
    cc ``@andoriyu``
    Dylan-DPC committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    212f703 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#86370 - matteo-briani:fix-rustdoc-stabilize…

    …d-versions-layout, r=GuillaumeGomez
    
    Fix rustdoc stabilized versions layout
    
    Fixes rust-lang#86342
    r? ``@GuillaumeGomez``
    Dylan-DPC committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    6b7ea65 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#86378 - Smittyvb:thir-walker-pat, r=LeSeulA…

    …rtichaut
    
    Add pattern walking support to THIR walker
    
    Suggested in rust-lang#85263 (comment), this splits off the support for pattern walking in THIR from rust-lang#85263. This has no observable effect on THIR unsafety checking, since it is not currently possible to trigger unsafety from the THIR checker using the additional patterns or constants that are now walked. THIR patterns are walked in source code order.
    
    r? `@LeSeulArtichaut`
    Dylan-DPC committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    f1a7e01 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#86397 - Eosis:alter-cell-docs, r=JohnTitor

    Alter std::cell::Cell::get_mut documentation
    
    I felt that there was some inconsistency between between Cell and RefCell with regards to their `get_mut` method documentation: `RefCell` flags this method as "unusual" in that it takes `&mut self`, while `Cell` does not. I attempted to flag this in `Cell`s documentation as well, and point to `RefCell`s method in the case where it is required.
    
    Find relevant parts of docs and the new version below.
    
    The current docs for `Cell::get_mut`:
    > Returns a mutable reference to the underlying data.
    This call borrows Cell mutably (at compile-time) which guarantees that we possess the only reference.
    
    And `RefCell::get_mut`:
    > Returns a mutable reference to the underlying data.
     This call borrows `RefCell` mutably (at compile-time) so there is no need for dynamic checks.
    However be cautious: this method expects self to be mutable, which is generally not the case when using a `RefCell`. Take a look at the `borrow_mut` method instead if self isn’t mutable.
    Also, please be aware that this method is only for special circumstances and is usually not what you want. In case of doubt, use `borrow_mut` instead.
    
    My attempt to make `Cell::get_mut` clearer:
    > Returns a mutable reference to the underlying data.
    This call borrows `Cell` mutably (at compile-time) which guaranteesthat we possess the only reference.
    However be cautious: this method expects `self` to be mutable, which is generally not the case when using a `Cell`. If you require interior mutability by reference, consider using `RefCell` which provides run-time checked mutable borrows through its `borrow_mut` method.
    Dylan-DPC committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    d55300b View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#86407 - LingMan:map-or, r=LeSeulArtichaut

    Use `map_or` instead of open-coding it
    
    ``@rustbot`` modify labels +C-cleanup +T-compiler
    Dylan-DPC committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    28a11f6 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#86426 - hi-rustin:rustin-patch-lint-warn, r…

    …=Aaron1011
    
    Lint for unused borrows as part of UNUSED_MUST_USE
    
    close rust-lang#76264
    
    base on rust-lang#76894
    
    r? `@RalfJung`
    Dylan-DPC committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    82ef6c8 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#86437 - nikomatsakis:tait-docs, r=oli-obk

    add various coments to explain how the TAIT code works
    
    r? `@oli-obk`
    Dylan-DPC committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    aa4a77f View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#86440 - rust-lang:libs-api-issue-template, …

    …r=m-ou-se
    
    Update library tracking issue for libs-api rename.
    Dylan-DPC committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    a9fd8cd View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#86444 - FabianWolff:issue-83505, r=LeSeulAr…

    …tichaut
    
    Fix ICE with `#[repr(simd)]` on enum
    
    This pull request fixes rust-lang#83505. `#[repr(simd)]` may only be applied to structs, which correctly causes `E0517` for the example given in rust-lang#83505, but the compiler attempts to recover from this error, which leads to an ICE later, when `.non_enum_variant()` is called on the `AdtDef`. I have added a check that prevents this from happening.
    Dylan-DPC committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    15c06b2 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#86453 - akiselev:patch-1, r=dtolnay

    stdlib: Fix typo in internal RefCell docs
    
    `BorroeError` => `BorrowError` in [cell.rs](https://github.com/rust-lang/rust/blob/master/library/core/src/cell.rs#L581)
    Dylan-DPC committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    5f90563 View commit details
    Browse the repository at this point in the history