Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 5 pull requests #97637

Closed
wants to merge 22 commits into from
Closed

Rollup of 5 pull requests #97637

wants to merge 22 commits into from

Commits on May 29, 2022

  1. Stop pretty-printing anonymous lifetimes.

    @cjgillot
    cjgillot committed May 29, 2022
    Configuration menu
    Copy the full SHA
    8da2707 View commit details
    Browse the repository at this point in the history

  2. Make lifetime errors more precise in the presence of Fresh lifetimes.

    @cjgillot
    cjgillot committed May 29, 2022
    Configuration menu
    Copy the full SHA
    da175c7 View commit details
    Browse the repository at this point in the history

  3. Fortify check for number of generic parameters.

    @cjgillot
    cjgillot committed May 29, 2022
    Configuration menu
    Copy the full SHA
    7b86c6f View commit details
    Browse the repository at this point in the history

  4. Handle anonymous lifetimes properly in diagnostics.

    @cjgillot
    cjgillot committed May 29, 2022
    Configuration menu
    Copy the full SHA
    3162b33 View commit details
    Browse the repository at this point in the history

  5. Rebase fallout.

    @cjgillot
    cjgillot committed May 29, 2022
    Configuration menu
    Copy the full SHA
    0cf79d7 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2022

  1. migrate maybe_recover_from_bad_qpath_stage_2 diagnostic

    @pvdrz
    pvdrz committed May 31, 2022
    Configuration menu
    Copy the full SHA
    bd4d1cd View commit details
    Browse the repository at this point in the history

  2. migrate maybe_consume_incorrect_semicolon diagnostic

    @pvdrz
    pvdrz committed May 31, 2022
    Configuration menu
    Copy the full SHA
    29ed9a5 View commit details
    Browse the repository at this point in the history

  3. migrate recover_from_await_method_call diagnostic

    @pvdrz
    pvdrz committed May 31, 2022
    Configuration menu
    Copy the full SHA
    93a427e View commit details
    Browse the repository at this point in the history

  4. use suggestion_short for incorrect semicolon diagnostic

    @pvdrz
    pvdrz committed May 31, 2022
    Configuration menu
    Copy the full SHA
    2a0496c View commit details
    Browse the repository at this point in the history

  5. migrate error_on_incorrect_await diagnostic

    @pvdrz
    pvdrz committed May 31, 2022
    Configuration menu
    Copy the full SHA
    a06ba45 View commit details
    Browse the repository at this point in the history

  6. merge diagnostics about incorrect uses of .await

    @pvdrz
    pvdrz committed May 31, 2022
    Configuration menu
    Copy the full SHA
    9ce04e3 View commit details
    Browse the repository at this point in the history

  7. migrate check_for_for_in_in_typo diagnostic

    @pvdrz
    pvdrz committed May 31, 2022
    Configuration menu
    Copy the full SHA
    e1d63d1 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2022

  1. rename sp to span

    @pvdrz
    pvdrz committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    0fa70a8 View commit details
    Browse the repository at this point in the history

  2. Add Symbol into rustdoc JSON ID to prevent conflicts between reexports

    @GuillaumeGomez
    GuillaumeGomez committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    410ffe3 View commit details
    Browse the repository at this point in the history

  3. Add regression test for json reexport bug

    @GuillaumeGomez
    GuillaumeGomez committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    069ae16 View commit details
    Browse the repository at this point in the history

  4. Stabilize box_into_pin

    @JohnTitor
    JohnTitor committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    572c390 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2022

  1. Revert rust-lang#96682. 

    The change was "Show invisible delimiters (within comments) when pretty
printing". It's useful to show these delimiters, but is a breaking
change for some proc macros.

Fixes rust-lang#97608.
    @nnethercote
    nnethercote committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    77e1069 View commit details
    Browse the repository at this point in the history

  2. Rollup merge of rust-lang#97023 - cjgillot:uniform-anon, r=estebank 

    Diagnose anonymous lifetimes errors more uniformly between async and regular fns

Async fns and regular fns are desugared differently.  For the former, we create a generic parameter at HIR level.  For the latter, we just create an anonymous region for typeck.

I plan to migrate regular fns to the async fn desugaring.

Before that, this PR attempts to merge the diagnostics for both cases.

r? ``@estebank``
    @Dylan-DPC
    Dylan-DPC committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    0ed450b View commit details
    Browse the repository at this point in the history

  3. Rollup merge of rust-lang#97397 - JohnTitor:stabilize-box-into-pin, r… 

    …=Mark-Simulacrum

Stabilize `box_into_pin`

FCP has been completed: rust-lang#62370 (comment)
Also, adds notes as per rust-lang#62370 (comment)
Closes rust-lang#62370
    @Dylan-DPC
    Dylan-DPC committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    78cd67b View commit details
    Browse the repository at this point in the history

  4. Rollup merge of rust-lang#97587 - pvdrz:maybe-recover-from-bad-qpath-… 

    …stage-2, r=davidtwco

Migrate more diagnostics to use the `#[derive(SessionDiagnostic)]`

r? `@davidtwco`
    @Dylan-DPC
    Dylan-DPC committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    6ee7bd3 View commit details
    Browse the repository at this point in the history

  5. Rollup merge of rust-lang#97599 - GuillaumeGomez:reexport-json, r=Cra… 

    …ftSpider

Fix JSON reexport ICE

Fixes rust-lang#97432.

The problem was that the ID was conflicting because the reexports have the same one. To fix it, I "extended" it by adding the `Symbol` into it as well.

r? `@notriddle`
    @Dylan-DPC
    Dylan-DPC committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    15c960b View commit details
    Browse the repository at this point in the history

  6. Rollup merge of rust-lang#97636 - nnethercote:revert-96682, r=dtolnay 

    Revert rust-lang#96682.

The change was "Show invisible delimiters (within comments) when pretty
printing". It's useful to show these delimiters, but is a breaking
change for some proc macros.

Fixes rust-lang#97608.

r? `@petrochenkov`
    @Dylan-DPC
    Dylan-DPC committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    249ffc0 View commit details
    Browse the repository at this point in the history