Module refactors #6062
Open
Module refactors #6062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camsteffen
force-pushed
the
module-refactor
branch
from
1ff061a
to
eb23a15
Compare
camsteffen
force-pushed
the
module-refactor
branch
from
eb23a15
to
2640a40
Compare
|
I'd like to land #5611 before taking a look at these changes. I'm not 100% sure if that will impact what you're trying to do here but I wanted to give you a heads up |
Make it so the field is only modified through a with_directory function so that it is easier to follow.
It's a little tricky to follow, but if you trace the code paths for inline modules and for external modules, this value is never actually used. This makes two functions more similar so that they can be deduped in a later commit.
This variant can be factored out fairly easily. It makes things simpler overall and opens the door for later refactors.
This makes some code DRYer since we don't need to use Cows and have different code paths for items with different lifetimes.
Defer creating a Module until needed. This is possible now that we are using arenas, so ast Items have the 'ast lifetime.
At this point it is just redundant with Module.items.
camsteffen
force-pushed
the
module-refactor
branch
from
2640a40
to
ba2f38d
Compare
|
I removed some commits to keep this PR focused on a series of related changes. I also took things a bit further by introducing an arena. I think this ultimately makes things simpler overall. I also added explanations on most individual commit messages. (I know we're waiting on #5611. It looks like that will be a pretty simple git conflict.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A set of refactors, mostly around modules.rs to make code DRYer and simpler. Review one commit at a time and note that some commits are prep work for later commits.