-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix free logic #64
Fix free logic #64
Conversation
f55f7f9
to
63df552
Compare
This fixes two bugs in the 0.10.0 release.
In order to test this, I've added a much more exhaustive test, which allocations and frees in a variety of different size, alignment, and free-order strategies. |
@phil-opp please release |
Thanks for the ping and sorry for the delay! I yanked v0.10.0 on crates.io and I will review this PR as soon as possible. Does this PR supersede your PR at #63, or should both be merged? |
No worries, thanks to both of you for creating fixes so quickly!
That would be great! I just set up a team for maintaining this crate and sent you an invite. You should then have crates.io access too. |
Got it! Let me know if you'd like me to merge this + release, otherwise I'll hold on for your review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't have time for an in-depth review, but the changes look all reasonable. Thanks again and sorry for the delay!
Feel free to merge and release this yourself, then we see if I set up the permissions correctly. For creating the releases of this crate, I use the cargo-release
tool, which will automatically bump the version number, create the release tags, and update the changelog headings. Just cargo release patch --execute
should be enough.
The existing 0.10.0 free logic can be incorrect in certain conditions. This can lead to failing assertions due to incorrect preconditions.
I plan to add tests to this to ensure that there are no additional issues, but this should likely be merged ASAP and 0.10.0 should be yanked.