Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various build fixes, including fixes to minimum version requirements #298

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

g2p
Copy link

@g2p g2p commented Oct 4, 2023

Tested with:

cargo +nightly update -Zminimal-versions
cargo check --all-features
cargo +nightly check --all-features --all-targets

@g2p
Copy link
Author

g2p commented Oct 4, 2023

Addresses #297. Ideally this would be tested in CI.

@g2p
Copy link
Author

g2p commented Oct 4, 2023

Build failure with rust 1.60 is unrelated; the following runs fine:

cargo +nightly update -Zminimal-versions
cargo +1.60 check --all-features

Check all features, check all targets (nightly only due to bench
targets), and check those again with minimum dependency resolution.
@JohnTitor
Copy link
Member

Well, have you run the above comment on workspace?

@g2p
Copy link
Author

g2p commented Oct 10, 2023

Yes. The command in the first post is the motivation for this PR, it didn't run in master, with correctly specified dependencies (proc-macro2 and trybuild) it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants