Macro support for uncased #309
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edef1c
force-pushed
the
uncased-macro
branch
from
97be044
to
3a86c8a
Compare
|
I ended up running into the same issue with macro-caused groups as @thaliaarchi, so that slightly expands the scope of this PR as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, macro support for uncased, since
UncasedStr::newis const now.Tests and examples matching the existing ones for Unicase are included.
I wrote this before noticing that #289 includes the same feature, and either will do, but I'm hoping a more focused PR has a better chance of getting merged.