Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PERT distribution for when mode is very close to (max - min) / 2 #1311

Closed
wants to merge 1 commit into from
Closed

Fix PERT distribution for when mode is very close to (max - min) / 2 #1311

wants to merge 1 commit into from

Commits on May 20, 2023

  1. Fix PERT distribution for when mode is very close to (max - min) / 2 

    There is already a special condition for this case, as the general
formula breaks for floats. However, the check uses `==` which is fishy
for floats. This commit instead checks if the difference is smaller than
the machine epsilon.

Without this commit, this returns an error (despite being totally valid
parameters for PERT):

    Pert::new(0.0, 0.48258883, 0.24129441)
    @LukasKalbertodt
    LukasKalbertodt committed May 20, 2023
    Configuration menu
    Copy the full SHA
    6f8437e View commit details
    Browse the repository at this point in the history