Minor grammar fixes #1338
Closed
Minor grammar fixes #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generally just a few misspelling mistakes. A few re-wording changes but nothing major.
dhardy
requested changes
Sep 15, 2023
| `rand_distr` each contain a lot of functionality. | ||
| - Simple (implementation). We have a strong focus on correctness, speed and flexibility, but | ||
| `rand_distr` each contains a lot of functionality. | ||
| - Simple (implementation). We have a strong focus on correctness, speed, and flexibility, but |
There was a problem hiding this comment.
I don't have anything against use of an Oxford comma here, but it's a matter of style rather than correctness.
| @@ -60,7 +60,7 @@ To get started using Rand, see [The Book](https://rust-random.github.io/book). | |||
| ## Versions | |||
|
|
|||
| Rand is *mature* (suitable for general usage, with infrequent breaking releases | |||
| which minimise breakage) but not yet at 1.0. We maintain compatibility with | |||
| that minimize breakage) but not yet at 1.0. We maintain compatibility with | |||
There was a problem hiding this comment.
| @@ -70,18 +70,18 @@ Current Rand versions are: | |||
| changes and fixes. | |||
| - Version 0.8 was released in December 2020 with many small changes. | |||
|
|
|||
| A detailed [changelog](CHANGELOG.md) is available for releases. | |||
| A detailed [changelog](CHANGELOG.md) is available for release. | |||
There was a problem hiding this comment.
This isn't a grammar change: it's a change of meaning. Write "for each release" if you prefer.
| [semver trick](https://github.com/dtolnay/semver-trick/) in order to make traits | ||
| [semver trick](https://github.com/dtolnay/semver-trick/) to make traits |
There was a problem hiding this comment.
The result is harder to parse. Revert please.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally just a few misspelling mistakes. A few re-wording changes but nothing major.