Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify macro implementation for tuples #1340

Merged
merged 1 commit into from Oct 11, 2023
Merged

Simplify macro implementation for tuples #1340

merged 1 commit into from Oct 11, 2023

Conversation

Lucretiel
Copy link
Contributor

  • We can now use a single macro, tuple_impls!(A B C), which "spreads" automatically to tuple_impl!(A), tuple_impl!(A B), etc
  • Simplify the input grammar to just a list of identifiers without other syntax
  • tuple_impl! now handles the empty tuple, and handles length-1 tuples without awkwardly positioned extra commas

@Lucretiel
Copy link
Contributor Author

Failure appears to be spurious— couldn't download a toolchain.

dhardy
dhardy approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@dhardy dhardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dhardy
Copy link
Member

dhardy commented Oct 11, 2023

The CI failure should be solved by #1341 / #1342.

@dhardy dhardy merged commit 9a02c81 into rust-random:master Oct 11, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhardy dhardy dhardy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Lucretiel @dhardy