Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak docs CI job #1451

Merged
merged 3 commits into from May 11, 2024
Merged

Tweak docs CI job #1451

merged 3 commits into from May 11, 2024

Conversation

newpavlov
Copy link
Member

The previous job haven't caught bad links in rand_core. The new job uses cargo doc directly instead of relying on cargo deadlinks, which should improve CI times a bit. We will not be able to check liveness of external links this way, but IIUC we did not do it either way.

@newpavlov newpavlov requested a review from dhardy May 10, 2024 11:05
Copy link
Member

@dhardy dhardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@newpavlov newpavlov merged commit 10a1fa4 into master May 11, 2024
14 checks passed
@newpavlov newpavlov deleted the docs_ci branch May 11, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants