Derive PartialEq+Eq. #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note this is dependent on rust-random/rand#975. |
dhardy
reviewed
May 4, 2020
rand_jitter/src/lib.rs
Outdated
| @@ -122,6 +122,7 @@ const MEMORY_SIZE: usize = MEMORY_BLOCKS * MEMORY_BLOCKSIZE; | |||
| /// | |||
| /// Note that this RNG is not suitable for use cases where cryptographic | |||
| /// security is required. | |||
| #[derive(PartialEq, Eq)] | |||
There was a problem hiding this comment.
Not this one — it's non-deterministic.
There was a problem hiding this comment.
Good catch, will fix.
|
Uh, there are two more changes to the |
|
Sorry about that, I'll revert them. Is maintaining a single squashed commit and force pushing an acceptable workflow? It would certainly make it easier for me to keep these things from slipping through, but I don't know if that's discouraged. |
|
Yes, squashing is fine with me (provided you're not making massive commits). |
This was referenced Jul 13, 2020
|
Implemented by #7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rust-random/rand#964.