On Web, implement DeviceEvents
#2871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
changed the title
DeviceEvent::MouseMotion to browser windowDeviceEvents
|
Just hit this bug on Mozilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1753724. Will figure out a fix. |
This was referenced Jun 11, 2023
Merged
daxpedda
force-pushed
the
web-device-event
branch
from
787b6e5
to
1ae95d2
Compare
|
I split off any pointer related fixes I originally implemented in this PR into #2878. |
daxpedda
force-pushed
the
web-device-event
branch
3 times, most recently
from
fe19240
to
cf940e8
Compare
daxpedda
force-pushed
the
web-device-event
branch
2 times, most recently
from
2aad007
to
414fad0
Compare
daxpedda
force-pushed
the
web-device-event
branch
from
414fad0
to
d083e4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking
MouseMotionMotionMouseWheelButtonKeyText(not implemented on any backend)Changes
This PR intends to implements all
DeviceEvents. AdditionallyDeviceEvents are only emitted according to the setting inEventLoopWindowTarget::listen_device_events().Fixes #2036.