Add github actions CI #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also cleanup the code, use rustfmt, and migrate to once_cell.
notgull
reviewed
Jun 3, 2023
| |name| unsafe { XkbCommon::open(name) }, | ||
| ) | ||
| }); | ||
| pub static XKBCOMMON_HANDLE: Lazy<&'static XkbCommon> = Lazy::new(|| { |
There was a problem hiding this comment.
I think it would be better to not expose the Lazy type, since OnceLock is now in std and making the once_cell crate a public dependency is fragile. I'd prefer an approach like this:
pub fn xkbcommon_handle() -> &'static XkbCommon {
static XKBCOMMON_HANDLE: OnceCell<XkbCommon> = OnceCell::new();
XKBCOMMON_HANDLE.get_or_init(|| /* ... */)
}This would need elinorbgr/dlib#21 to be released first.
There was a problem hiding this comment.
Yeah, we can open follow up for that, I wouldn't release this crate for a while.
The crate on its own is weird and its scope is sort of limited, as in for winit only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also cleanup the code, use rustfmt, and migrate to once_cell.