Work around firefox webextensions bug #249
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, looks like this work around is not good enough. While the wasm module does instantiate fine, it still raises an error |
|
Now this should work. Instead of using |
1 task
|
It seems as a fix for the Firefox bug is underway. I would say we shouldn't merge this and let Firefox handle it. |
kmusick
added a commit
to kmusick/uuid
that referenced
this pull request
Jun 21, 2023
…bAssembly.Instance(): Import uuid-rs#9 module="./index_bg.js" function="__wbg_now_dc6f7ce2227b5592" error: function import requires a callable" Similar issue: rustwasm/gloo#249
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing
gloo_timersin firefox webextension's content script results in an error:LinkError: import object field '__wbg_clearTimeout_65417660fe82f08d' is not a FunctionIt actually seems to be a firefox bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1787770
This can simply be worked around by refering to timer functions using window object (setInterval -> window.setInterval) which this PR does. I do not think this would impact users outside of webextensions in any way, as window.setInterval and setInterval are the same functions in usual context (but apparently not in content scripts...)