Add option to spawn workers as a module #421
Conversation
There was a problem hiding this comment.
Thanks for the pull request.
TBH, I am fine with switching to ESModule-only for the Worker implementation since all major browser has support of it, the ESModule adoption for Web Worker is pretty overdue at this point of time.
However, it is also good to have a non-breaking upgrade path so people are not forced to switch immediately.
|
Every major browser supports it so I don't see the need to keep the no-modules around. There is no user code that needs to be updated, as far as I'm aware, as all the JS is generated by wasm-bindgen and it calls WASM. |
JonasAlaif
force-pushed
the
spawn-options
branch
4 times, most recently
from
2b207f1
to
44b25d5
Compare
|
I've changed the default to spawn the worker as a module (which means that this will be a breaking change), but I think it's worthwhile keeping the old behavior around for backwards compatibility reasons. |
This would allow creating workers with the `--target web` flag, alleviating the current missing features described [here](https://rustwasm.github.io/wasm-bindgen/examples/without-a-bundler.html?highlight=no-modules#using-the-older---target-no-modules)
JonasAlaif
force-pushed
the
spawn-options
branch
from
44b25d5
to
d263d22
Compare
|
Ready to merge now. Will be a breaking change regardless, since both the public API of spawner is changed as well as the default |
|
@hamza1311 or @futursolo if you have time :) |
|
This is ready to be merged @hamza1311 @futursolo |
|
I really need this PR. Any timeline when it will be available? |
Workers created with the
--target webflag must be spawned as a module. This adds the option to do that, alleviating the current--target no-modulesmissing features described here. I will create a linked PR in trunk to add an option to create workers with this flag.