Raw identifiers cause error

[cam-narzt]

Describe the Bug

Trying to use a struct with a raw identifier in wasm causes an error to be thrown.

Steps to Reproduce

use wasm_bindgen::prelude::*;
#[wasm_bindgen]
pub struct Column {
  pub r#type: u8,
}

Expected Behavior

I expect valid rust to compile to valid wasm.

Actual Behavior

rustc: custom attribute panicked

Additional Context

Docs about raw identifiers

[daxpedda]

Happy to review a PR fixing this!
Should be pretty straightforward with syn.

[Liamolucko]

quote::format_ident will probably be useful here (similar to #3541).

EDIT: or maybe unraw. The idents often seem to have already been converted to strings by the time formatting is happening, so that might be easier.

[Solo-steven]

Hi, I would like to take this issue, and I believe we can simply solve it by adding format_ident to theree and add format_ident to make js_name handle raw identifier correctly.

wasm-bindgen/crates/macro-support/src/parser.rs

Line 422 in 373b7a5

let (js_field_name, member) = match &field.ident {

it seems that unraw method belongs to the Ident structure in syn crate, but the Ident structure we use seems from the proc_macro mostly, so I think if we gonna using unraw method, maybe we need to convert Ident from proc_macro to ident from syn crate/

[daxpedda]

It sounds to me like format_ident should do the trick then if unraw requires unnecessary conversions.
I'm happy to review a PR.

[Liamolucko]

it seems that unraw method belongs to the Ident structure in syn crate, but the Ident structure we use seems from the proc_macro mostly, so I think if we gonna using unraw method, maybe we need to convert Ident from proc_macro to ident from syn crate/

We're using proc_macro2::Ident, not proc_macro::Ident, and syn::Ident is just a re-export of proc_macro2::Ident, so there's no conversion needed.

[Solo-steven]

Hi @Liamolucko thanks for your reply, You are right! it's my fault that confused with proc_macro and proc_marco2, unraw would work as format_ident, thanks for your catch ~