Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle raw identifier in field #3621

Merged
merged 12 commits into from Sep 20, 2023

Conversation

Solo-steven
Copy link
Contributor

fix #3586, using Ident.unraw to handle raw identifier.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think you can add a test for this somewhere into the existing ones?

Otherwise LGTM!

@Solo-steven
Copy link
Contributor Author

Hi @daxpedda, sure! I think I can add a test in tests/wasm/getter_and_setter.rs, It is correctly place to add test case ?

@daxpedda
Copy link
Collaborator

Apologies for the delay!

I think I can add a test in tests/wasm/getter_and_setter.rs, It is correctly place to add test case ?

That seems fine to me.

@Solo-steven
Copy link
Contributor Author

Hi @daxpedda, it is ok! and thanks for your reply. There is a question for running tests when I follow the guide and run

cargo test --target wasm32-unknown-unknown

my computer throws some error and shows that process panic,

Try find `webdriver.json` for configure browser's capabilities:
Ok
driver status: signal: 9 (SIGKILL)                
Error: http://127.0.0.1:52624/session: status code 500
error: test failed, to rerun pass `--test headless`

Caused by:
  process didn't exit successfully: `cargo run -p wasm-bindgen-cli --bin wasm-bindgen-test-runner -- /Users/litingwei/Desktop/projects/for-osp/wasm-bindgen/target/wasm32-unknown-unknown/debug/deps/headless-4e40f55ce9c3cd6d.wasm` (exit status: 1)

Did I miss something to configure, I haven't changed the webdriver.json yet, thanks for any help, and sorry for bothering you again.

@daxpedda
Copy link
Collaborator

The error usually has nothing to do with the webdriver.json, you could try using WASM_BINDGEN_SPLIT_LINKED_MODULES=1.
Honestly though, the problem here is missing documentation on how to run the tests properly on a local machine. If this doesn't solve your problem I recommend you to not waste any time on this and just use the CI to run tests.

[..], thanks for any help, and sorry for bothering you again.

No, thank you for your contribution, you are helping us here!

tests/wasm/getters_and_setters.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI says formatting still has to be fixed.
Other then the nit LGTM.

tests/wasm/getters_and_setters.rs Outdated Show resolved Hide resolved
Co-authored-by: daxpedda <daxpedda@gmail.com>
@daxpedda daxpedda added the waiting for author Waiting for author to respond label Sep 19, 2023
@Solo-steven
Copy link
Contributor Author

CI says formatting still has to be fixed. Other then the nit LGTM.

Hi @daxpedda, thanks for your review, I fixed the fmt problem, thanks ~

Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@daxpedda daxpedda merged commit 9ae2a60 into rustwasm:main Sep 20, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for author Waiting for author to respond
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raw identifiers cause error
2 participants