New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use table.fill
in externref-xform (TODO
)
#3446
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First off: this is amazing, thank you!
As far as I know the reference-type proposal is not a requirements for the atomic proposal, so either we will have to adjust the documentation or gate it.
I would prefer to gate it, which should be possible.
Will pull in alexcrichton when we are ready to review this, I don't feel comfortable enough with Wasm's instruction set to approve this.
I don't understand where gating makes sense. The |
Ah, apologies! For some reason I thought we are in |
Yes I believe that this is correct but I'm also not sure whether it's worth doing. For small sizes it may be better to have the currently unrolled loop perf-wise and it may only be advantageous for larger sizes to use |
I would have argued that loop unrolling is a compilers job when it's applying optimizations, on the other hand this is not something I really know much about. @lukaslihotzki would you mind researching this a bit:
Thank you! |
No description provided.