Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export JsValue from js-sys #3466

Merged
merged 5 commits into from
Jun 25, 2023
Merged

Export JsValue from js-sys #3466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eb2ee8d
Export JsValue from js-sys
kajacx Jun 6, 2023
7a6efe9
Re-export the entire wasm-bindgen crate instead
kajacx Jun 6, 2023
83ba66c
Add a link to the PR in the changelog
kajacx Jun 6, 2023
51a4111
Update crates/js-sys/CHANGELOG.md
kajacx Jun 24, 2023
cc03d6b
Re-export js-sys and wasm-bindgen from web-sys
kajacx Jun 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion crates/js-sys/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@ Released YYYY-MM-DD.

### Added

* TODO (or remove section if none)
* Re-export `wasm-bindgen` from `js-sys` and `web-sys`.
[#3466](https://github.com/rustwasm/wasm-bindgen/pull/3466)

* Re-export `js-sys` from `web-sys`.
[#3466](https://github.com/rustwasm/wasm-bindgen/pull/3466)

### Changed

Expand Down
1 change: 1 addition & 0 deletions crates/js-sys/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ use std::mem;
use std::str;
use std::str::FromStr;

pub use wasm_bindgen;
daxpedda marked this conversation as resolved.
Show resolved Hide resolved
use wasm_bindgen::prelude::*;
daxpedda marked this conversation as resolved.
Show resolved Hide resolved

// When adding new imports:
Expand Down
3 changes: 3 additions & 0 deletions crates/web-sys/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@
mod features;
pub use features::*;

pub use js_sys;
pub use wasm_bindgen;

/// Getter for the `Window` object
///
/// [MDN Documentation]
Expand Down