Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle raw identifiers in wasm_bindgen_test macro #3541

Merged
merged 4 commits into from
Aug 5, 2023
Merged

Handle raw identifiers in wasm_bindgen_test macro #3541

merged 4 commits into from
Aug 5, 2023

Commits on Aug 2, 2023

  1. Handle raw identifiers in wasm_bindgen_test macro 

    Currently the use of raw identifiers in test names produces an invalid
function name. `Ident::new` panics whenever it encounters the `r#`
prefix, instead `Ident::new_raw` should be used.

However, the `__wbgt` prefix we append helps form a valid identifier
already. So removing the "r#" prefix is the only thing required.

Fixes rustwasm#3288

Signed-off-by: Oliver T <geronimooliver00@gmail.com>
    @snOm3ad
    snOm3ad committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    980699a View commit details
    Browse the repository at this point in the history

  2. Rust fmt 

    Signed-off-by: Oliver T <geronimooliver00@gmail.com>
    @snOm3ad
    snOm3ad committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    3b86db3 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2023

  1. changelog entry

    @snOm3ad
    snOm3ad committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    8f06bbb View commit details
    Browse the repository at this point in the history

  2. changed to format_ident 

    Signed-off-by: Oliver T <geronimooliver00@gmail.com>
    @snOm3ad
    snOm3ad committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    d92aab4 View commit details
    Browse the repository at this point in the history