Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constructor, replace, and replaceSync methods to CssStyleSheet #3573

Merged
merged 6 commits into from Aug 30, 2023

Conversation

ngryman
Copy link
Contributor

@ngryman ngryman commented Aug 26, 2023

Hey,

Pretty much as the title says :)

The constructor I added is not fully compliant with the specs as it doesn't accept options. I've done that to simplify things. Let me know if I should include them in this PR though.

Co-authored-by: daxpedda <daxpedda@gmail.com>
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, I keep forgetting that: could you also add a changelog entry?

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@daxpedda daxpedda merged commit 86fd961 into rustwasm:main Aug 30, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants