Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add attribute crate to proc-macro wasm-bindgen-test #3593

Merged
merged 3 commits into from Sep 4, 2023
Merged

Add attribute crate to proc-macro wasm-bindgen-test #3593

merged 3 commits into from Sep 4, 2023

Conversation

FirelightFlagboy
Copy link
Contributor

@FirelightFlagboy FirelightFlagboy commented Sep 4, 2023 •
edited

Also rework how the attributes of the proc-macro are parsed using syn (it was simpler to handle an attribute that has a value).

Closes #3588

@FirelightFlagboy FirelightFlagboy mentioned this pull request Sep 4, 2023
Closed
@daxpedda daxpedda self-assigned this Sep 4, 2023
@daxpedda daxpedda added the waiting for author Waiting for author to respond label Sep 4, 2023
daxpedda
daxpedda reviewed Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the current failure is because wasm-bindgen-test-macro isn't defining the full feature set it requires from syn? But LGTM otherwise.

Gonna review it as soon as CI passes.

@FirelightFlagboy FirelightFlagboy force-pushed the 3588-crate-attr-in-wasm-bindgen-test branch from 4ae9cdd to e8650f6 Compare September 4, 2023 11:17
daxpedda
daxpedda requested changes Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, I forgot: could you also add an entry in the changelog?

LGTM otherwise.

@FirelightFlagboy
Add attribute crate to proc-macro wasm_bindgen_test
5bea714 
This attribute allow to specify a path where `wasm-bindgen-test` can be
accessed.

Closes rustwasm#3588
@FirelightFlagboy FirelightFlagboy force-pushed the 3588-crate-attr-in-wasm-bindgen-test branch from e8650f6 to 5bea714 Compare September 4, 2023 13:50
daxpedda
daxpedda reviewed Sep 4, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@daxpedda daxpedda merged commit 41617bd into rustwasm:main Sep 4, 2023
@daxpedda
Copy link
Collaborator

daxpedda commented Sep 4, 2023

Thanks!

@FirelightFlagboy FirelightFlagboy deleted the 3588-crate-attr-in-wasm-bindgen-test branch September 4, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxpedda daxpedda daxpedda requested changes

Assignees

@daxpedda daxpedda

Labels
waiting for author Waiting for author to respond
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support crate attribute in proc-macro wasm_bindgen_test
2 participants
@FirelightFlagboy @daxpedda