Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental ViewTransition interface #3598

Merged
merged 3 commits into from Sep 7, 2023
Merged

Conversation

tigerros
Copy link
Contributor

@tigerros tigerros commented Sep 6, 2023

This adds the experimental ViewTransition interface. See MDN docs and W3C specs. I hope experimental APIs are allowed.

I followed the contributing guidelines, but let me know if I did something wrong.

Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Could you add an entry to the changelog?

@daxpedda daxpedda added the waiting for author Waiting for author to respond label Sep 7, 2023
@tigerros
Copy link
Contributor Author

tigerros commented Sep 7, 2023

Added.

Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Just waiting for CI.

@daxpedda daxpedda removed the waiting for author Waiting for author to respond label Sep 7, 2023
@daxpedda daxpedda merged commit 2c62271 into rustwasm:main Sep 7, 2023
25 checks passed
@tigerros
Copy link
Contributor Author

tigerros commented Sep 7, 2023

@daxpedda I wanted to ask an additional question, when can it be moved into the webidls/enabled directory? I looked at the contributing guide and there was no mention of this.

@daxpedda
Copy link
Collaborator

daxpedda commented Sep 7, 2023

We don't have any official guidelines for this. Basically when we think that the API isn't going to change anymore.

It's a candidate recommendation, so I'm assuming this isn't going to change anymore, but it's only implemented by Chromium and has very low usage across the web.

Considering how close this is to recommendation I would prefer to wait unless there is a strong incentive otherwise.

@tigerros
Copy link
Contributor Author

tigerros commented Sep 7, 2023

Alright. If you're wondering, the reason why I added this is because someone requested this as a feature (as in, a framework API around it) in Dioxus, which is an SPA framework and thus would benefit quite a bit from this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants