Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unwrap argument types in macro #3625

Merged
merged 7 commits into from
Sep 20, 2023
Merged

Unwrap argument types in macro #3625

merged 7 commits into from
Sep 20, 2023

Commits on Sep 19, 2023

  1. Unwrap argument types in macro 

    `syn` wraps argument types in a `syn::TypeGroup` for free
functions/methods generated from `macro_rules!` this means that
references end up generating wrong code during proc macro expansion.

This PR unwraps argument types in `syn::TypeGroup` and matches against
the inner element for such cases.

Fixes rustwasm#3078

Signed-off-by: Oliver T <geronimooliver00@gmail.com>
    @snOm3ad
    snOm3ad committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    f76f20e View commit details
    Browse the repository at this point in the history

  2. Add changelog entry + rustfmt 

    Signed-off-by: Oliver T <geronimooliver00@gmail.com>
    @snOm3ad
    snOm3ad committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    3e735e9 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. handle nesting 

    Signed-off-by: Oliver T <geronimooliver00@gmail.com>
    @snOm3ad
    snOm3ad committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    f6ce82c View commit details
    Browse the repository at this point in the history

  2. fix clippy + add cli test 

    Signed-off-by: Oliver T <geronimooliver00@gmail.com>
    @snOm3ad
    snOm3ad committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    632abe6 View commit details
    Browse the repository at this point in the history

  3. moved cli test to tests/wasm 

    Signed-off-by: Oliver T <geronimooliver00@gmail.com>
    @snOm3ad
    snOm3ad committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    76591c1 View commit details
    Browse the repository at this point in the history

  4. rustfmt 

    Signed-off-by: Oliver T <geronimooliver00@gmail.com>
    @snOm3ad
    snOm3ad committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    7029903 View commit details
    Browse the repository at this point in the history

  5. fix clippy 

    Signed-off-by: Oliver T <geronimooliver00@gmail.com>
    @snOm3ad
    snOm3ad committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    8c59a67 View commit details
    Browse the repository at this point in the history