Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally enable bindings for wasm32-wasi with --wasi flag #3673

Closed
wants to merge 4 commits into from
Closed

Conditionally enable bindings for wasm32-wasi with --wasi flag #3673

wants to merge 4 commits into from

Conversation

temeddix
Copy link

@temeddix temeddix commented Oct 30, 2023

With #3233(Jan 2023), generating bindings for WASI was disabled.

However, with #3595(Sep 2023) wasm-bindgen gained compatibility with wasm32-wasi's standard C ABI. It was stated in #3454 by @Liamolucko that wasm-bindgen already supports the standard C ABI that wasm32-wasi uses.

This PR aims to enable bindings for wasm32-wasi under the new --wasi flag. This will allow ecosystem around wasm-bindgen such as wasm-pack to make use of wasm32-wasi.

I'm very open to feedback, so please tag me if there's room for improvements. I should perhaps add or modify some tests for now.

@temeddix temeddix changed the title Enable binding generation for wasm32-wasi with --wasi flag Enable bindings for wasm32-wasi with --wasi flag Oct 30, 2023
@temeddix temeddix changed the title Enable bindings for wasm32-wasi with --wasi flag Enable bindings for wasm32-wasi conditionally with --wasi flag Oct 30, 2023
@temeddix temeddix changed the title Enable bindings for wasm32-wasi conditionally with --wasi flag Conditionally enable bindings for wasm32-wasi with --wasi flag Oct 30, 2023
@daxpedda
Copy link
Collaborator

Personally I have stated in #3421 why I think enabling wasm32-wasi in wasm-bindgen directly is a mistake.

So I think the way forward here is to continue discussion in #3421 to see if we can find a good reason to actually support that.

@daxpedda daxpedda closed this Oct 30, 2023
@daxpedda
Copy link
Collaborator

Also, please make sure it makes sense to move forward with a PR before you make one with us. It feels really bad closing PRs like that, I prefer not to waste anybodies time.

@temeddix temeddix mentioned this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants