Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow SharedArrayBuffer to be passed to DataView constructor #3695

Merged
merged 5 commits into from
Nov 10, 2023
Merged

Allow SharedArrayBuffer to be passed to DataView constructor #3695

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
41a1883
Allow SharedArrayBuffer to be passed to DataView constructor
kyledecot Nov 9, 2023
f822639
Use separate constructor to maintain type safety
kyledecot Nov 9, 2023
b9ac1df
Fix formatting
kyledecot Nov 9, 2023
22eaedf
Update CHANGELOG.md
kyledecot Nov 10, 2023
38901c4
Update wording
daxpedda Nov 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/js-sys/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1596,7 +1596,7 @@ extern "C" {
///
/// [MDN documentation](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/DataView)
#[wasm_bindgen(constructor)]
pub fn new(buffer: &ArrayBuffer, byteOffset: usize, byteLength: usize) -> DataView;
pub fn new(buffer: &JsValue, byteOffset: usize, byteLength: usize) -> DataView;
daxpedda marked this conversation as resolved.
Show resolved Hide resolved

/// The ArrayBuffer referenced by this view. Fixed at construction time and thus read only.
///
Expand Down