Implement RTCRtpSender.getCapabilities method
#3737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
requested changes
Dec 7, 2023
| @@ -74,6 +81,7 @@ interface RTCRtpSender { | |||
| RTCRtpParameters getParameters(); | |||
| Promise<undefined> replaceTrack(MediaStreamTrack? withTrack); | |||
| Promise<RTCStatsReport> getStats(); | |||
| static RTCRtpCapabilities getCapabilities(DOMString kind); | |||
There was a problem hiding this comment.
Suggested change
| static RTCRtpCapabilities getCapabilities(DOMString kind); | |
| static RTCRtpCapabilities? getCapabilities(DOMString kind); |
Comment on lines
71
to
74
| dictionary RTCRtpCapabilities { | ||
| sequence<RTCRtpCodecParameters> codecs; | ||
| sequence<RTCRtpHeaderExtensionParameters> headerExtensions; | ||
| }; |
There was a problem hiding this comment.
Where exactly did you get this from?
Suggested change
| dictionary RTCRtpCapabilities { | |
| sequence<RTCRtpCodecParameters> codecs; | |
| sequence<RTCRtpHeaderExtensionParameters> headerExtensions; | |
| }; | |
| dictionary RTCRtpCapabilities { | |
| required sequence<RTCRtpCodecCapability> codecs; | |
| required sequence<RTCRtpHeaderExtensionCapability> headerExtensions; | |
| }; |
Comment on lines
41
to
42
| DOMString scalabilityMode; | ||
| RTCRtpCodecParameters codec; |
There was a problem hiding this comment.
Suggested change
| DOMString scalabilityMode; | |
| RTCRtpCodecParameters codec; |
This whole type seems to be wrong, but where did you get these added fields from?
There was a problem hiding this comment.
Unfortunately, I have not found these fields in the current spec.
I have seen these fields there:
There was a problem hiding this comment.
Adding these bindings seems fine to me, but they would have to be added as unstable as far as I can see.
daxpedda
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds spec compliant
getCapabilitiesmethod forRTCRtpSender. Also adds theRTCRtpCapabilitiesdictionary and thecodecandscalabilityModefields for theRTCRtpEncodingParameters.