Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing HtmlFormElement::request_submit method #3747

Merged
merged 3 commits into from Dec 20, 2023
Merged

Add missing HtmlFormElement::request_submit method #3747

merged 3 commits into from Dec 20, 2023

Conversation

sciguy16
Copy link
Contributor

Add the HtmlFormElement::request_submit* methods that were missing from the IDL file in web-sys

https://developer.mozilla.org/en-US/docs/Web/API/HTMLFormElement/requestSubmit
https://html.spec.whatwg.org/#htmlformelement

daxpedda
daxpedda requested changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a note in the changelog?
Otherwise LGTM!

@sciguy16
Copy link
Contributor Author

Thanks! I've updated the changelog

daxpedda
daxpedda reviewed Dec 20, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@daxpedda daxpedda merged commit a070715 into rustwasm:main Dec 20, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxpedda daxpedda daxpedda requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sciguy16 @daxpedda