Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement getters for WebIDL dictionaries #3933

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Implement getters for WebIDL dictionaries #3933

wants to merge 9 commits into from

Commits on Apr 24, 2024

  1. Implement getters for WebIDL dictionaries

    @pablosichert
    pablosichert committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    8139d75 View commit details
    Browse the repository at this point in the history

  2. Use to_syn_type(TypePosition::Return) to determine return type of g… 

    …etter
    @pablosichert
    pablosichert committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    9aaac2b View commit details
    Browse the repository at this point in the history

  3. Reference setters explicitly with Self:: in new to avoid ambiguit… 

    …y with getter trait
    @pablosichert
    pablosichert committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    128e678 View commit details
    Browse the repository at this point in the history

  4. Fix tests by not importing ${X}Getters traits through * import

    @pablosichert
    pablosichert committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    1f2d9b4 View commit details
    Browse the repository at this point in the history

  5. Test roundtrip of setting and getting properties

    @pablosichert
    pablosichert committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    914f54b View commit details
    Browse the repository at this point in the history

  6. Test setting/getting c: OtherDict

    @pablosichert
    pablosichert committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    eacb790 View commit details
    Browse the repository at this point in the history

  7. Test setting/getting properties through nested dictionary

    @pablosichert
    pablosichert committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    9440e4e View commit details
    Browse the repository at this point in the history

  8. Apply clippy::question_mark suggestion

    @pablosichert
    pablosichert committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    1241704 View commit details
    Browse the repository at this point in the history

  9. Fix webidl-tests/unstable

    @pablosichert
    pablosichert committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    6bc1cca View commit details
    Browse the repository at this point in the history