Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dispatch_event to take Event or CustomEvent #3938

Closed
wants to merge 2 commits into from
Closed

Update dispatch_event to take Event or CustomEvent #3938

wants to merge 2 commits into from

Conversation

SorenHolstHansen
Copy link

@SorenHolstHansen SorenHolstHansen commented Apr 26, 2024 •
edited

This updates the dispatch_event method on EventTarget to take either Event or CustomEvent

@SorenHolstHansen SorenHolstHansen changed the title add dispatch_custom_event to enable dispatching CustomEvent's Update dispatch_event to take Event or CustomEvent Apr 26, 2024
@Liamolucko
Copy link
Collaborator

CustomEvent is a subclass of Event, so this shouldn't be necessary. You can convert a CustomEvent into an Event via. its Deref<Target = Event> impl.

This would also be a breaking change.

@SorenHolstHansen
Copy link
Author

CustomEvent is a subclass of Event, so this shouldn't be necessary. You can convert a CustomEvent into an Event via. its Deref<Target = Event> impl.

This would also be a breaking change.

Thanks, didn't know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SorenHolstHansen @Liamolucko