Fix clippy lint empty_docs
#3946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kflansburg
changed the title
clippy lint about empty docstringclippy lint empty_docs
Liamolucko
reviewed
May 7, 2024
There was a problem hiding this comment.
Thanks!
Can you add a changelog entry?
CI should be fixed by #3949 if you rebase.
kflansburg
force-pushed
the
kflansburg/fix-empty-doc-comment
branch
from
ceabebe
to
5f13de2
Compare
kflansburg
force-pushed
the
kflansburg/fix-empty-doc-comment
branch
from
5f13de2
to
536bd7e
Compare
Liamolucko
approved these changes
May 8, 2024
2 tasks
daxpedda
pushed a commit
to daxpedda/wasm-bindgen
that referenced
this pull request
May 21, 2024
* Do not include docstring if empty Closes rustwasm#3945 * Move changelog entry to correct section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there may be more locations where this should be done, but its only impacting structs for me.
Closes #3945