Migrate to 2018 edition and update dependencies #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkettelhoit
force-pushed
the
update-deps
branch
from
94d5ba0
to
416d71d
Compare
|
@fkettelhoit Thanks a lot! I will go through this more closely in a while, I think this will be released in |
|
Migrate to edition 2021 may be another choice |
|
Any help needed with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates to the 2018 edition and updates all dependencies in a way that no duplicate dependencies are pulled in, which resolves the issues #798 and #801.
Before the PR:
$ cargo tree --duplicates | wc -l 398After:
$ cargo tree --duplicates | wc -l 0Make sure these boxes are checked! 📦✅
rustfmtinstalledcargo fmton the code base before submitting✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨