Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize #1267

Open
wants to merge 88 commits into
base: master
Choose a base branch
from
Open

Optimize #1267

wants to merge 88 commits into from

Conversation

dullbananas
Copy link

@dullbananas dullbananas commented Apr 2, 2023 •
edited

This slightly improve performance. Most overhead is from running things such as wasm-bindgen, wasm-opt, and rustc --version.

Helps with #1260

Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed
$ rustup component add rustfmt
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

@dullbananas
Optimize get_process_steps
4f29034
@dullbananas
Use Vec::with_capacity in check_wasm_pack_lastet_version
8ac82f2
@dullbananas
Use &'static str for local version
08a66e6
@dullbananas
Optimize version check
9d37592
@dullbananas
Reduce conversions from OsString to String
85586ee
@dullbananas
Reduce heap allocations
114d12b
@dullbananas
Add benchmark
ade563a
@dullbananas
increase warm up time
dd71328
@dullbananas
Allow unused
87e0e26
@dullbananas
More optimization
b5f7654
@dullbananas
Optimize rustc version check
0dc955d
@dullbananas
Clippy
cca671c
@dullbananas
More optimization
3f35b47
@dullbananas
Add perf feature
836fe7d
@dullbananas
Refactor run_step
130e237
@dullbananas
Optimize lockfile
4d90f54
@dullbananas
Use iai benchmark
0725710
@dullbananas
Fix bench
204b138
@dullbananas
Add more benchmarks
2db60b3
@dullbananas
Stuff
c6f1b56
@dullbananas
Clippy
1b6f23f
@dullbananas
Optimize initialization
f74de45
@dullbananas
Add Tool::name
afc9ed2
@dullbananas
Use Command::args
d328240
@dullbananas
Make installation check 47% faster with multithreading
3a96012
@dullbananas
Optimize string conversion
1c7700a
@dullbananas
Optimize handling of unused cargo.toml fields
8fe5017
@dullbananas
Clippy
4549771
@dullbananas
Return Cow from find_pkg_directory
c9bce17
@dullbananas
Revert "Return Cow from find_pkg_directory"
1fe302c 
This reverts commit c9bce17.
@dullbananas
Multithreaded checks
8376336
@dullbananas
Optimize lockfile
86fd962
@dullbananas
Add dhat heap profiler
b6d095c
@dullbananas
Add FixtureBuilder for parallel file writes
32c6248
@dullbananas
Refactor lockfile name filtering
d692fc7
@dullbananas
Use Command::args with slices (partial)
592be5b
@dullbananas
Revert "Use Command::args with slices (partial)"
04fb5a1 
This reverts commit 592be5b.
@dullbananas
Use Command::args with arrays
31751f8
@dullbananas
Remove rust file
db8ba8e
@dullbananas
Revert "Remove rust file"
a5d1e8e 
This reverts commit db8ba8e.
@dullbananas
Revert "Revert "Remove rust file""
45dc394 
This reverts commit a5d1e8e.
@dullbananas
Add args directly in npm_login
7f39506
@dullbananas
Use trim_backtraces(None)
eaf3430
@dullbananas
Optimize usage of cargo_metadata (removes most memory usage)
6d56036
@dullbananas
Avoid running which if wasm target is found
01d0912
@dullbananas
Optimize lockfile
dc9e99c
@dullbananas
Replace structopt with clap (allocations increased)
0692377
@dullbananas
Revert "Use Command::args with arrays"
ba4c902 
This reverts commit 31751f8.
@dullbananas
Run step_check_crate_config in main thread
6440129
@dullbananas
Avoid calls to serde_ignored callback
845638b
@dullbananas
Merge remote-tracking branch 'upstream/master'
28ff353
@dullbananas
Move FixtureBuilder::new to Fixture::new
7cd74e9
@dullbananas
Revert "Replace structopt with clap (allocations increased)"
07ab317 
This reverts commit 0692377.
@dullbananas
Refactor
9fa1f80
@dullbananas
Revert "Move FixtureBuilder::new to Fixture::new"
13e3c63 
This reverts commit 7cd74e9.
@dullbananas
Revert "Add FixtureBuilder for parallel file writes"
cf4961a 
This reverts commit 32c6248.
@dullbananas
Merge branch 'master' into master
59e707a
@dullbananas
Reduce use statement diff
d493270
@dullbananas
Fix my botched merge conflict resolution
406ef37
@dullbananas dullbananas marked this pull request as ready for review June 17, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dullbananas