Ensure that the static array backend's scratch heap is page-aligned #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 28, 2019
fitzgen
force-pushed
the
align-static-array-scratch-heap
branch
2 times, most recently
from
72e4e5d
to
6be49c1
Compare
fitzgen
force-pushed
the
align-static-array-scratch-heap
branch
3 times, most recently
from
3fb01e6
to
cd40b2c
Compare
fitzgen
force-pushed
the
align-static-array-scratch-heap
branch
from
cd40b2c
to
816eca6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically, at minimum we only assert that
imp::alloc_pagesreturns a block of memory that is word-aligned, but it makes sense to me to keep it "page"-aligned as that is the granularity of allocation in the backend (this might be a system without virtual memory, so "page" is maybe a misnomer).This should help with #85
@ZackPierce or @DrGoldfire could you take a look at this?
+cc @nand-nor