Merge branch 'hotfix/1.29.3' into stable

.travis.yml

@@ -1,5 +1,5 @@
 language: c
-os: [linux, osx]
+os: [osx, linux]
 sudo: false
 addons:
   apt:
@@ -10,7 +10,8 @@ before_install:
   - "sed -i'' -e '/rvm_project_rvmrc/d ; /rvm_silence_path_mismatch_check_flag/d' ~/.rvmrc || true"
   - "echo rvm_show_log_lines_on_error=all >> ~/.rvmrc"
   - "head -n 100 /etc/rvmrc ~/.rvmrc || true"
-  - rvm use ruby-2.0.0 --fuzzy
+  - rvm list
+  - "rvm use ruby-2.4 --fuzzy || rvm use ruby-2.3 --fuzzy"
   - "[[ -n \"${LANG:-}\" ]] || export LANG=en_US.UTF-8"
   - "env | grep '^rvm' || true"
 install:
@@ -25,7 +26,10 @@ before_script:
   - git submodule init
   - git submodule update
 script:
-  - tf --text rvm-test/fast/* rvm-test-rvm1/*
+  - tf --text $TEST
+env:
+  - TEST=rvm-test/fast/* rvm-test-rvm1/*
+  - TEST=rvm-test/long/named_ruby_and_gemsets_comment_test.sh
 matrix:
   include:
     - os: linux
@@ -43,7 +47,7 @@ notifications:
     on_failure: change
   slack:
     rooms:
-      secure: "On6pWKbXoqul6b7/Ye17oVNFMIrkmAojrDtGzF6xgHrTPw2fdQQh6i0EskEZUL0ibDPF1oR0C7MJwGkEPhF7Tc3la/TFKnBIHoH+5c8TWt08f2mof6o8eGbx8HfsHMrG+DwHUjVqOHPiTd8AzeogLyZ2UrM3wBm9Bo7f9obYzRQ="
+      secure: KUEuifsnQ76ZZRj/5V2uFEtv0u3irvAdOSEHps/0MSLo2mkJAeja8L4salKKEIsvh3Ftl4t6Bs2z6sut2L5Bu0JlU1UBXtNe0QuYpBs5UL7kv7lxIbnGlQDvAmDjmItVMDg0cSSNfegl6t0xQknO4V7PUu7xNkfQkh+FklvFBBI=
     on_success: change
     on_failure: always
-    on_pull_requests: false
+    on_pull_requests: true

CHANGELOG.md

@@ -2,8 +2,104 @@
 
 ## [Unreleased](https://github.com/rvm/rvm/tree/HEAD)
 
-[Full Changelog](https://github.com/rvm/rvm/compare/1.29.1...HEAD)
+[Full Changelog](https://github.com/rvm/rvm/compare/1.29.3...HEAD)
 
+###
+
+[1.29.2](https://github.com/rvm/rvm/tag/1.29.3)
+10 September 2017 - [Full Changelog](https://github.com/rvm/rvm/compare/1.29.2...1.29.3)
+
+#### New features:
+* Add RVM commands missing in bash shell completion [\#4078](https://github.com/rvm/rvm/pull/4078)
+* Railsexpress patches for 2.3.4 and 2.3-head [\#4084](https://github.com/rvm/rvm/pull/4084)
+* Update gem-wrappers to 1.3.0: Show warnings when the target binary is missing or is not executable [gem-wrappers \#9](https://github.com/rvm/gem-wrappers/issues/9)
+* Detect Zorin OS as Ubuntu [\#4140](https://github.com/rvm/rvm/issues/4140)
+* Railsexpress patches for 2.2.5 and 2.2.6 [\#4153](https://github.com/rvm/rvm/pull/4153)
+
+#### Bug fixes:
+* Infinite loop in `gemset_create` [\#4102](https://github.com/rvm/rvm/issues/4102)
+* Command not found `__rvm_remote_version` error [\#4085](https://github.com/rvm/rvm/pull/4085)
+* Fix path of version script in `environment` [\#4117](https://github.com/rvm/rvm/pull/4117)
+* Define cd(), pushd() and popd() properly when using zsh [\#4132](https://github.com/rvm/rvm/pull/4132)
+* Update gem-wrappers to 1.3.1: Avoid warnings for missing ruby binaries [\#4104](https://github.com/rvm/rvm/issues/4104)
+* Handles :engine=> and :engine_version=> in Gemfile
+* Makes $rvm_ruby_string is not installed searchable by adding a fixed keyword
+* Correctly quotes suggested install command
+* Fix path to version script in rvm-installer [\#4134](https://github.com/rvm/rvm/pull/4134)
+* Fix rvm autolibs status, fix [\#4123](https://github.com/rvm/rvm/issues/4123)
+* Ruby 2.3.x and older are not compatible with OpenSSL 1.1.x on Arch [\#4006](https://github.com/rvm/rvm/issues/4006)
+* Allow comments after ruby directive in Gemfile [\#4056](https://github.com/rvm/rvm/issues/4056)
+* Ruby 2.3/4 compilation fix for GCC 7 [\#4080](https://github.com/rvm/rvm/issues/4080) [\#4115](https://github.com/rvm/rvm/issues/4115)
+* Add warning for sudo users [\#4009](https://github.com/rvm/rvm/issues/4009)
+* Allows running RVM shell function in Bash with `set -o nounset` [\#4013](https://github.com/rvm/rvm/issues/4013)
+* Ensure rvm_hooks_path is set [\#3902](https://github.com/rvm/rvm/issues/3902)
+* Allow building static ruby with --disbale-shared [\#4091](https://github.com/rvm/rvm/issues/4091)
+* Restore detection of `gpg` command for veryfication of signatures [\#4059](https://github.com/rvm/rvm/issues/4059)
+* Update gem-wrappers to 1.3.2: Avoid nested chdir warnings [gem-wrappers \#11](https://github.com/rvm/gem-wrappers/pull/11)
+
+#### Upgraded Ruby interpreters:
+* Add support for Rubinius 3.82, 3.83, 3.84
+* Add support for mruby 1.3.0
+* Upgrade RubyGems to 2.6.13 [\#4142](https://github.com/rvm/rvm/pull/4142)
+* Add support for JRuby 9.1.13.0 [\#4147](https://github.com/rvm/rvm/pull/4147)
+
+### Documentation
+* Remove `wayneeseguin` reference from RVM repo names [\#4086](https://github.com/rvm/rvm/pull/4086)
+
+[1.29.2](https://github.com/rvm/rvm/tag/1.29.2)
+
+#### New features:
+* Add support for elementary OS [\#3935](https://github.com/rvm/rvm/issues/3935)
+* Add support for Deepin (based on Debian) [\#3999](https://github.com/rvm/rvm/issues/3999)
+* Simplified OS detection mechanism [\#3938](https://github.com/rvm/rvm/pull/3938)
+* Use fuzzy version match for `rvm remove` [\#4028](https://github.com/rvm/rvm/pull/4028)
+* Simplify and cleanup of `rvm help` output [\#4029](https://github.com/rvm/rvm/pull/4029)
+* Add support for Kali Linux (based on Debian) [\#3958](https://github.com/rvm/rvm/issues/3958)
+* Railsexpress patches for 2.4.0, 2.4.1 and 2.4-head [\#4050](https://github.com/rvm/rvm/pull/4050)
+
+#### Bug fixes:
+* Use actual executable test instead of mount|grep noexec for robust noexec detection [\#3933](https://github.com/rvm/rvm/pull/3933)
+* "Unknown ruby string (do not know how to handle)" when specifying Ruby version w/a gemset [\#3292](https://github.com/rvm/rvm/issue/3292)
+* Fix the required openssl version for ruby 1.8 on OSX [\#3955](https://github.com/rvm/rvm/issue/3955)
+* Detect `.` as an alternative to `source` in bash profile warning [\#3960](https://github.com/rvm/rvm/issues/3960)
+* Allow users to specify irb history file using IRB.conf[:HISTORY_FILE] [\#3969](https://github.com/rvm/rvm/pull/3969)
+* Prefer github issues over IRC support [\#3939](https://github.com/rvm/rvm/issues/3939)
+*	Architecture detection using uname instead of dpkg [\#3948](https://github.com/rvm/rvm/issues/3948)
+* Help section of the rvm.io page points to irc.freenode.net instead of github [\#3939](https://github.com/rvm/rvm/issues/3939)
+* Make sure stderr output is printed on console and not captured into log files [\#3990](https://github.com/rvm/rvm/issues/3990)
+* Clean up errors output, show only log file name [\#3990](https://github.com/rvm/rvm/issues/3990)
+* RVM install fail on macOS Yosemite due expired curl's SSL certificate [\#3886](https://github.com/rvm/rvm/issues/3886)
+* Fix failing openssl.patch for Ruby 2.2.4 and 2.2.5 [\#3988](https://github.com/rvm/rvm/issues/3988)
+* Do not unset rvm_pretty_print_flag [\#3946](https://github.com/rvm/rvm/issues/3946)
+* Patch Ruby 2.3.4 with missing rb_thread_fd_close [\#4008](https://github.com/rvm/rvm/issues/4008)
+* Unknown subcommand `rvm gemset clear` [\#4004](https://github.com/rvm/rvm/issues/4004)
+* Skip rubygems install for ruby-head [\#4022](https://github.com/rvm/rvm/pull/4022)
+* Fix match MacPorts in non standard location [\#4051](https://github.com/rvm/rvm/pull/4051)
+* Ruby 2.3.3 doesn't compile on Debian 8.3 [\#4000](https://github.com/rvm/rvm/issues/4000)
+* Ruby < 2.4 fail to build on Fedora 26 [\#4057](https://github.com/rvm/rvm/issues/4057)
+
+#### Upgraded Ruby interpreters:
+* Add support for Rubinius 3.72 [\#3934](https://github.com/rvm/rvm/pull/3934), 3.73 [\#3979](https://github.com/rvm/rvm/pull/3979), 3.74 [\#3994](https://github.com/rvm/rvm/pull/3994), 3.75 [\#4002](https://github.com/rvm/rvm/pull/4002), 3.76 and 3.77 [\#4016](https://github.com/rvm/rvm/pull/4016), 3.78, 3.79, 3.80, 3.81
+* Add support for Ruby 2.2.7 [\#3970](https://github.com/rvm/rvm/pull/3970), 2.3.4 [\#3973](https://github.com/rvm/rvm/pull/3973) and 2.4.1 [\#3963](https://github.com/rvm/rvm/pull/3963)
+* Upgrade RubyGems to 2.6.12 [\#4018](https://github.com/rvm/rvm/pull/4018)
+* Add support for JRuby 1.7.27 [\#4026](https://github.com/rvm/rvm/pull/4026), 9.1.8.0 [\#3952](https://github.com/rvm/rvm/pull/3952), 9.1.9.0 [\#4036](https://github.com/rvm/rvm/pull/4036), 9.1.10.0 [\#4049](https://github.com/rvm/rvm/pull/4049), 9.1.11 [\#4064](https://github.com/rvm/rvm/issues/4064) and 9.1.12.0 [\#4066](https://github.com/rvm/rvm/issues/4066)
+
+#### Binaries:
+* Ubuntu x64 binary for Ruby 2.4.1 [\#3965](https://github.com/rvm/rvm/issues/3965)
+* Ubuntu x64 binary for Ruby 2.2.7 [\#3971](https://github.com/rvm/rvm/issues/3971)
+* Ubuntu x64 binary for Ruby 2.3.4 [\#3985](https://github.com/rvm/rvm/issues/3985)
+* Ubuntu 16.10 x64 binaries for Ruby 1.9.3-p551, 2.0.0-p648, 2.1.5, 2.1.6, 2.1.8, 2.1.9, 2.2.4, 2.2.5, 2.2.6, 2.3.0, 2.3.1, 2.3.2 and 2.3.3 [\#3823](https://github.com/rvm/rvm/issues/3823)
+
+#### Documentation:
+* Integrating RVM with Bash on Ubuntu on Windows 10 [\#304](https://github.com/rvm/rvm-site/pull/304)
+* Troubleshooting SSL certificate problem: unable to get local issuer certificate [\#3984](https://github.com/rvm/rvm/issue/3984)
+* Automatically generated Integration section on Index page [\#305](https://github.com/rvm/rvm-site/pull/305)
+* Add info about Ubuntu installation package [\#306](https://github.com/rvm/rvm-site/pull/306)
+* Remove subversion as a prerequisite for installing rubies [\#277](https://github.com/rvm/rvm-site/issue/277)
+* Added missing information that user should have sudo rights to install rubies [\#307](https://github.com/rvm/rvm-site/pull/307)
+* Better explanation for `apt-get update` failing with 404 Not Found errors [\#3411](https://github.com/rvm/rvm/issue/3411)
+* Ruby 2.1 is no more maintained [\#3997](https://github.com/rvm/rvm/pull/3997)
+* Display deprecation notice for `rvm usage` [\#4047](https://github.com/rvm/rvm/pull/4047)
 
 ## [1.29.1](https://github.com/rvm/rvm/tag/1.29.1)
 
@@ -16,6 +112,7 @@
 * Add explicit architecture check for debian/ubuntu [\#3927](https://github.com/rvm/rvm/issues/3927)
 * Fix detecting openssl path for ruby24 [\#3928](https://github.com/rvm/rvm/issues/3928)
 
+
 ## [1.29.0](https://github.com/rvm/rvm/tag/1.29.0)
 
 12 February 2017 - [Full Changelog](https://github.com/rvm/rvm/compare/1.28.0...1.29.0)
@@ -43,11 +140,11 @@
 * Changed `eval` to `source` for fish 2.5.0 compatibility [fish-shell\#3809](https://github.com/fish-shell/fish-shell/issues/3809)
 * $PATH become empty after __rvm_unload executed [\#3847](https://github.com/rvm/rvm/pull/3847)
 * RVM incorrectly tries to install llvm 3.5 when trying to install Rubinius 3 [\#3848](https://github.com/rvm/rvm/pull/3848)
-* Missing libyaml-devel on PCLinuxOS 64-bit [\#3703](https://github.com/rvm/rvm/issues/3703) 
+* Missing libyaml-devel on PCLinuxOS 64-bit [\#3703](https://github.com/rvm/rvm/issues/3703)
 * Failing openssl.patch for Ruby 1.9.3 [\#3831](https://github.com/rvm/rvm/issues/3831)
 * RVM hardcodes number of compile threads [\#3856](https://github.com/rvm/rvm/pull/3856)
 * Cannot build rbx-2.5.2 on ArchLinux [\#3497](https://github.com/rvm/rvm/issues/3497)
-* Remove incompatible version of openssl098 [\#3844](https://github.com/rvm/rvm/issues/3844) 
+* Remove incompatible version of openssl098 [\#3844](https://github.com/rvm/rvm/issues/3844)
 * Failed to fetch the gpg key from keys.gnupg.net [\#3544](https://github.com/rvm/rvm/issues/3544)
 * Filtering Travis binaries for OSX for non Travis env (they are statically linked and not movable) [\#3690](https://github.com/rvm/rvm/issues/3690)
 * Remove kernel-libc-devel dependency on Solus [\#3881](https://github.com/rvm/rvm/pull/3881)
@@ -59,7 +156,7 @@
 * Missing `libgmp3-dev` for Ruby 2.2 on Debian 6 [\#3675](https://github.com/rvm/rvm/issues/3675)
 * JRuby on Arch is missing Java requirements [\#3539](https://github.com/rvm/rvm/issues/3539)
 * `rvm install 2.4` installs 2.4.0-rc1 instead of 2.4.0 [\#3866](https://github.com/rvm/rvm/issues/3866)
-* Use `libreadline-dev` instead of `libreadline6-dev` on Debian (≥stretch) [\#3824](https://github.com/rvm/rvm/issues/3824)
+* Use `libreadline-dev` instead of `libreadline6-dev` on Debian (???stretch) [\#3824](https://github.com/rvm/rvm/issues/3824)
 * Warning: openssl is a keg-only and another version is linked to opt [\#3724](https://github.com/rvm/rvm/issues/3724)
 * Fix trusting paths with duplicated //
 * Fix rvm do in relative paths
@@ -73,7 +170,6 @@
 #### Binaries:
 * Ubuntu x64 binary for Ruby 2.4.0 [\#3867](https://github.com/rvm/rvm/issues/3867)
 
-
 ## [1.28.0](https://github.com/rvm/rvm/tag/1.28.0)
 
 19 December 2016 - [Full Changelog](https://github.com/rvm/rvm/compare/1.27.0...1.28.0)

FORMATTING.md

@@ -1,26 +1,26 @@
 # general
 
-1. Try to make code readable, it's the most important rule,
-turn your eyes away from code and look on it again,
-can you really fast understand it - if no - reformat to make it better.
+1. Try to make code readable. This is the most important rule.
+Turn your eyes away from code and look on it again.
+If you cannot quickly understand the code, reformat to make it better.
 
-2. Avoid semicolons, just because they make code harder to read (look rule 1).
+2. Avoid semicolons, just because they make code harder to read (see rule 1).
 
 # variables
 
 ## defining
 ```bash
-typeset var          # avid local - it breaks code in some rare cases
+typeset var          # avoid local - it breaks code in some rare cases
 typeset -a arr
-arr=()               # define and reset array, required for arr+=( ... )
+arr=()               # define and reset array. required for arr+=( ... )
 typeset -x important # the same export, just for consistency
 ```
 
 Variables defined in one local in function are available in all other functions called by it.
 
 ## numeric variables comparison
 ```bash
-: variable:${variable:=0} # make sure it is set and simplifies debugging
+: variable:${variable:=0} # Ensures it is set and simplifies debugging
 (( variable ))      # when not zero
 (( variable == 0 )) # when zero
 : $(( variable++ )) # increase