added 'append_system_gemsets' feature for multiuser mode #3473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if (( rvm_append_system_gemsets )) | ||
| then | ||
| GEM_PATH="$GEM_PATH:$rvm_ruby_gem_system_path" |
There was a problem hiding this comment.
no need for this, rvm_ruby_gem_path should be updated, see bellow
|
left some notes how to make it better, also would you be able to update https://github.com/rvm/rvm/blob/master/help/user.md? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
I've implemented mixing user's and system gemsets for multi-user mode. It allows to use a large set of system-wide gems with a compact user-specific gem sets. Please take a look.
It appends system gems directories (from ruby's primary gem home and '@global') to the GEM_PATH environment variable and the directories of gem's binaries to the PATH, allowing to use user installed gems and system gems together.
The feature adds '--append-system-gemsets' argument to the 'rvm user' command and saves 'rvm_append_system_gemsets' flag in the user's rvmrc file. Than If the flag is on, it appends system gems pathes to GEM_PATH and PATH.