Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync openmandriva file accroding to fedora, with various fixes, to pr… #4394

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

fedya
Copy link
Contributor

@fedya fedya commented May 31, 2018

…event issues with dnf migration, switch to dnf from urpmi

Changes proposed in this pull request:

  • openmandriva migrated to dnf from urpm package manager

Make sure that your pull request includes entry in the CHANGELOG.

Copy link
Member

@mpapis mpapis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job here, any chance we can keep the old code running for old versions of openmandriva?

scripts/functions/requirements/openmandriva Show resolved Hide resolved
@fedya
Copy link
Contributor Author

fedya commented Aug 29, 2018

I updated my commit, rosadesktop now is separate distro.

@fedya
Copy link
Contributor Author

fedya commented Sep 3, 2018

bump request

@tpgxyz
Copy link

tpgxyz commented Sep 4, 2018

@mpapis can you please review this PR, as we the OpenMandriva developers are blocked with getting things together on our infrastructure without this PR in rvm.

@mpapis
Copy link
Member

mpapis commented Sep 4, 2018

Hey, is it possible to make an change to add openmandriva_old? to maintain the old code - for users who still use the old systems? I'm fine with any solution like openmandriva_dnf.

@fedya
Copy link
Contributor Author

fedya commented Sep 4, 2018

openmandriva > openmandriv_dnf
add openmandriva_old

@mpapis
Copy link
Member

mpapis commented Sep 4, 2018

great, last thing - a router is still missing, please have a look at https://github.com/rvm/rvm/blob/f1b2c7890a0875e427818edafd76b4994e42eec6/scripts/functions/requirements/osx

could you rebase the branch on master?

Aleksandr Stefanov and others added 4 commits September 5, 2018 03:28
@fedya
Copy link
Contributor Author

fedya commented Sep 5, 2018

Router added

@tpgxyz
Copy link

tpgxyz commented Sep 7, 2018

@mpapis please review it and merge

scripts/functions/requirements/openmandriva Show resolved Hide resolved

requirements_rosadesktop_before()
requirements_openmandriva_before()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I much more prefer how it is done in https://github.com/rvm/rvm/blob/master/scripts/functions/requirements/fedora#L25

So basically detect which version (dnf or rpm) to use and then source the right file implementing all functions. Detection can be done like in fedora by checking dnf or for a system version or any other method which is appropriate...

Could u implement the same way, please?

@@ -1 +0,0 @@
openmandriva
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the new file just a copy of scripts/functions/requirements/openmandriva_old? Then better to do:

source "$rvm_scripts_path/functions/requirements/openmandriva_old"

requirements_rosadesktop_define()
{
  __lib_type=openmandriva
  requirements_openmandriva_define "$@"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants