-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync openmandriva file accroding to fedora, with various fixes, to pr… #4394
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job here, any chance we can keep the old code running for old versions of openmandriva?
I updated my commit, rosadesktop now is separate distro. |
bump request |
@mpapis can you please review this PR, as we the OpenMandriva developers are blocked with getting things together on our infrastructure without this PR in rvm. |
Hey, is it possible to make an change to add |
openmandriva > openmandriv_dnf |
great, last thing - a router is still missing, please have a look at https://github.com/rvm/rvm/blob/f1b2c7890a0875e427818edafd76b4994e42eec6/scripts/functions/requirements/osx could you rebase the branch on master? |
…event issues with dnf migration, switch to dnf from urpmi
…ibility, because of openmandriva migrated to DNF stack, and rosa still uses urpm
…p backward compatibility
Router added |
@mpapis please review it and merge |
This line is not needed when `requirements_rosadesktop_define` exists
New line
|
||
requirements_rosadesktop_before() | ||
requirements_openmandriva_before() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I much more prefer how it is done in https://github.com/rvm/rvm/blob/master/scripts/functions/requirements/fedora#L25
So basically detect which version (dnf or rpm) to use and then source the right file implementing all functions. Detection can be done like in fedora by checking dnf
or for a system version or any other method which is appropriate...
Could u implement the same way, please?
@@ -1 +0,0 @@ | |||
openmandriva |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the new file just a copy of scripts/functions/requirements/openmandriva_old
? Then better to do:
source "$rvm_scripts_path/functions/requirements/openmandriva_old"
requirements_rosadesktop_define()
{
__lib_type=openmandriva
requirements_openmandriva_define "$@"
}
…event issues with dnf migration, switch to dnf from urpmi
Changes proposed in this pull request:
Make sure that your pull request includes entry in the CHANGELOG.