Modify fairings #2598
Open
Modify fairings #2598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the codegen for routes to use a method on the proxy object, rather than implementing a trait on the proxy object. This helps rustc identify unused routes, although it may break compatibility for some specific use cases.
- Change to different signatures for simplicity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes: #2271
Resolves: #2271
Adds a modify_fairings method to make changes to fairings before launch.
There were several comments on the original PR, which have been resolved. Some simplification of the API has been performed. Now also enables
trait_upcastingon nightly, to avoid unsafe code.