Partially revert 86c9ff1 Add static template hoisting to SSR #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah.. I'd seen some weird stuff recently but didn't know where it was coming from. For some reason everything time I did module clear and full re-install things were fine. We make heavy use of state in Marko so I was really liking the convenience of the approach but I can revert for now I guess. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 86c9ff1, state for templates and events was moved from
path.scope.datatopath.state. Newer versions of babel have a bug with the way thatTraversalContexts are tracked and it can causepath.stateto be clobbered. This issue manifests itself when other babel plugins (notably@babel/plugin-proposal-class-properties) are used that visit the same AST nodes. This pull request moves template and events state back topath.scope.data.The issue seems to have first occurred after this babel/babel#12302
I believe this unfinished PR will fix the
TraversalContextbug babel/babel#12634